store test [nfc]: Inline checkReloadFailure helper at both callsites

For zulip#1354, we'll need an alternative to TestGlobalStore that runs
UpdateMachine.load with prepared API responses instead of mocking
it. Since FakeApiConnection doesn't yet offer a `Completer`-based
way of completing/awaiting requests, these two tests will have to
diverge, preparing and awaiting different delays as needed.

Author: chrisbobbe

test/model/store_test.dart

@@ -991,13 +991,15 @@ void main() {
       check(store).isLoading.isTrue();
     }
 
-    void checkReloadFailure(FakeAsync async, {
-      required FutureOr<void> Function() completeLoading,
-    }) async {
+    test('user logged out before new store is loaded', () => awaitFakeAsync((async) async {
       await prepareReload(async);
       check(completers()).single.isCompleted.isFalse();
 
-      await completeLoading();
+      // [PerAccountStore.fromInitialSnapshot] requires the account
+      // to be in the global store when called; do so before logging out.
+      final newStore = eg.store(globalStore: globalStore, account: eg.selfAccount);
+      await logOutAccount(globalStore, eg.selfAccount.id);
+      completers().single.complete(newStore);
       check(completers()).single.isCompleted.isTrue();
       check(globalStore.takeDoRemoveAccountCalls()).single.equals(eg.selfAccount.id);
 
@@ -1007,26 +1009,23 @@ void main() {
       async.flushTimers();
       // Reload never succeeds and there are no unhandled errors.
       check(globalStore.perAccountSync(eg.selfAccount.id)).isNull();
-    }
-
-    Future<void> logOutAndCompleteWithNewStore() async {
-      // [PerAccountStore.fromInitialSnapshot] requires the account
-      // to be in the global store when called; do so before logging out.
-      final newStore = eg.store(globalStore: globalStore, account: eg.selfAccount);
-      await logOutAccount(globalStore, eg.selfAccount.id);
-      completers().single.complete(newStore);
-    }
-
-    test('user logged out before new store is loaded', () => awaitFakeAsync((async) async {
-      checkReloadFailure(async, completeLoading: logOutAndCompleteWithNewStore);
     }));
 
-    void completeWithApiExceptionUnauthorized() {
+    test('new store is not loaded, gets HTTP 401 error instead', () => awaitFakeAsync((async) async {
+      await prepareReload(async);
+      check(completers()).single.isCompleted.isFalse();
+
       completers().single.completeError(eg.apiExceptionUnauthorized());
-    }
+      async.elapse(Duration.zero);
+      check(completers()).single.isCompleted.isTrue();
+      check(globalStore.takeDoRemoveAccountCalls()).single.equals(eg.selfAccount.id);
 
-    test('new store is not loaded, gets HTTP 401 error instead', () => awaitFakeAsync((async) async {
-      checkReloadFailure(async, completeLoading: completeWithApiExceptionUnauthorized);
+      async.elapse(TestGlobalStore.removeAccountDuration);
+      check(globalStore.perAccountSync(eg.selfAccount.id)).isNull();
+
+      async.flushTimers();
+      // Reload never succeeds and there are no unhandled errors.
+      check(globalStore.perAccountSync(eg.selfAccount.id)).isNull();
     }));
   });