Commit e8b3b5f
committed
store [nfc]: Re-query account after _registerQueueWithRetry async gap
I believe this is NFC because:
- the only fields we read are zulipVersion, zulipMergeBase, and
zulipFeatureLevel
- we read those fields only to update them if needed
- nothing else could have written to those fields during the async
gap; this register-queue codepath is the only codepath that writes
to them, and we don't allow concurrent register-queues for an
account
But we've been using an Account object from across an async gap, and
that looks like a code smell that calls for a fix.1 parent 1d812f4 commit e8b3b5f
1 file changed
+2
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
976 | 976 | | |
977 | 977 | | |
978 | 978 | | |
| 979 | + | |
| 980 | + | |
979 | 981 | | |
980 | 982 | | |
981 | 983 | | |
| |||
0 commit comments