msglist: Tapping a message in Starred or Mentions opens anchored msglist

Fixes zulip#1621.

Author: chrisbobbe

lib/widgets/message_list.dart

@@ -1,3 +1,5 @@
+import 'dart:async';
+
 import 'package:collection/collection.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_color_models/flutter_color_models.dart';
@@ -974,6 +976,16 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat
     }
   }
 
+  /// Whether tapping a message should open its conversation.
+  bool get _tapMessageOpensConversation => switch (widget.narrow) {
+    CombinedFeedNarrow()
+      || ChannelNarrow()
+      || TopicNarrow()
+      || DmNarrow() => false,
+    MentionsNarrow()
+      || StarredMessagesNarrow() => true,
+  };
+
   Widget _buildItem(MessageListItem data) {
     switch (data) {
       case MessageListRecipientHeaderItem():
@@ -990,10 +1002,16 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat
         return MessageItem(
           key: ValueKey(data.message.id),
           header: header,
-          item: data);
+          item: data,
+          tapOpensConversation: _tapMessageOpensConversation,
+        );
       case MessageListOutboxMessageItem():
         final header = RecipientHeader(message: data.message, narrow: widget.narrow);
-        return MessageItem(header: header, item: data);
+        return MessageItem(
+          header: header,
+          item: data,
+          tapOpensConversation: _tapMessageOpensConversation,
+        );
     }
   }
 }
@@ -1317,10 +1335,12 @@ class MessageItem extends StatelessWidget {
     super.key,
     required this.item,
     required this.header,
+    required this.tapOpensConversation,
   });
 
   final MessageListMessageBaseItem item;
   final Widget header;
+  final bool tapOpensConversation;
 
   @override
   Widget build(BuildContext context) {
@@ -1331,7 +1351,10 @@ class MessageItem extends StatelessWidget {
       color: designVariables.bgMessageRegular,
       child: Column(children: [
         switch (item) {
-          MessageListMessageItem() => MessageWithPossibleSender(item: item),
+          MessageListMessageItem() => MessageWithPossibleSender(
+            item: item,
+            tapOpensConversation: tapOpensConversation,
+          ),
           MessageListOutboxMessageItem() => OutboxMessageWithPossibleSender(item: item),
         },
         // TODO refine this padding; discussion:
@@ -1748,9 +1771,14 @@ class _SenderRow extends StatelessWidget {
 //   - https://github.com/zulip/zulip-mobile/issues/5511
 //   - https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=538%3A20849&mode=dev
 class MessageWithPossibleSender extends StatelessWidget {
-  const MessageWithPossibleSender({super.key, required this.item});
+  const MessageWithPossibleSender({
+    super.key,
+    required this.item,
+    required this.tapOpensConversation,
+  });
 
   final MessageListMessageItem item;
+  final bool tapOpensConversation;
 
   @override
   Widget build(BuildContext context) {
@@ -1800,6 +1828,13 @@ class MessageWithPossibleSender extends StatelessWidget {
 
     return GestureDetector(
       behavior: HitTestBehavior.translucent,
+      onTap: tapOpensConversation
+        ? () => unawaited(Navigator.push(context,
+            MessageListPage.buildRoute(context: context,
+              narrow: SendableNarrow.ofMessage(message, selfUserId: store.selfUserId),
+              // TODO(#1655) "this view does not mark messages as read on scroll"
+              initAnchorMessageId: message.id)))
+        : null,
       onLongPress: () => showMessageActionSheet(context: context, message: message),
       child: Padding(
         padding: const EdgeInsets.only(top: 4),

test/widgets/message_list_checks.dart

@@ -4,4 +4,5 @@ import 'package:zulip/widgets/message_list.dart';
 
 extension MessageListPageChecks on Subject<MessageListPage> {
   Subject<Narrow> get initNarrow => has((x) => x.initNarrow, 'initNarrow');
+  Subject<int?> get initAnchorMessageId => has((x) => x.initAnchorMessageId, 'initAnchorMessageId');
 }

test/widgets/message_list_test.dart

@@ -1653,6 +1653,78 @@ void main() {
 
       debugNetworkImageHttpClientProvider = null;
     });
+
+    group('Opens conversation on tap?', () {
+      // (copied from test/widgets/content_test.dart)
+      Future<void> tapText(WidgetTester tester, Finder textFinder) async {
+        final height = tester.getSize(textFinder).height;
+        final target = tester.getTopLeft(textFinder)
+          .translate(height/4, height/2); // aim for middle of first letter
+        await tester.tapAt(target);
+      }
+
+      final subscription = eg.subscription(eg.stream(streamId: eg.defaultStreamMessageStreamId));
+      final topic = 'some topic';
+
+      void doTest(Narrow narrow, bool expected, {required Message Function() mkMessage}) {
+        testWidgets('${expected ? 'yes' : 'no'}, if in $narrow', (tester) async {
+          final message = mkMessage();
+
+          Route<dynamic>? lastPushedRoute;
+          final navObserver = TestNavigatorObserver()
+            ..onPushed = ((route, prevRoute) => lastPushedRoute = route);
+
+          await setupMessageListPage(
+            tester,
+            narrow: narrow,
+            messages: [message],
+            subscriptions: [subscription],
+            navObservers: [navObserver]
+          );
+          lastPushedRoute = null;
+
+          // Tapping interactive content still works.
+          await store.handleEvent(eg.updateMessageEditEvent(message,
+            renderedContent: '<p><a href="https://example/">link</a></p>'));
+          await tester.pump();
+          await tapText(tester, find.text('link'));
+          await tester.pump(Duration.zero);
+          check(lastPushedRoute).isNull();
+          final launchUrlCalls = testBinding.takeLaunchUrlCalls();
+          check(launchUrlCalls.single.url).equals(Uri.parse('https://example/'));
+
+          // Tapping non-interactive content opens the conversation (if expected).
+          await store.handleEvent(eg.updateMessageEditEvent(message,
+            renderedContent: '<p>plain content</p>'));
+          await tester.pump();
+          await tapText(tester, find.text('plain content'));
+          if (expected) {
+            final expectedNarrow = SendableNarrow.ofMessage(message, selfUserId: store.selfUserId);
+
+            check(lastPushedRoute).isNotNull().isA<MaterialAccountWidgetRoute>()
+              .page.isA<MessageListPage>()
+                ..initNarrow.equals(expectedNarrow)
+                ..initAnchorMessageId.equals(message.id);
+          } else {
+            check(lastPushedRoute).isNull();
+          }
+
+          // TODO test tapping whitespace in message
+        });
+      }
+
+      doTest(CombinedFeedNarrow(), false, mkMessage: () => eg.streamMessage());
+      doTest(ChannelNarrow(subscription.streamId), false,
+        mkMessage: () => eg.streamMessage(stream: subscription));
+      doTest(TopicNarrow(subscription.streamId, eg.t(topic)), false,
+        mkMessage: () => eg.streamMessage(stream: subscription));
+      doTest(DmNarrow.withUsers([], selfUserId: eg.selfUser.userId), false,
+        mkMessage: () => eg.streamMessage(stream: subscription, topic: topic));
+      doTest(StarredMessagesNarrow(), true,
+        mkMessage: () => eg.streamMessage(flags: [MessageFlag.starred]));
+      doTest(MentionsNarrow(), true,
+        mkMessage: () => eg.streamMessage(flags: [MessageFlag.mentioned]));
+    });
   });
 
   group('OutboxMessageWithPossibleSender', () {