compose_box test: Switch to using subscribed channels, where boring

It's way more common to be using the app with subscribed channels
than unsubscribed channels, so we might as well test with subscribed
channels except where we specifically want to check behavior for
unsubscribed channels.

Author: chrisbobbe

test/widgets/compose_box_test.dart

@@ -160,7 +160,7 @@ void main() {
       final channel = eg.stream();
       await prepareComposeBox(tester,
         narrow: ChannelNarrow(channel.streamId),
-        streams: [channel],
+        subscriptions: [eg.subscription(channel)],
         messages: [eg.streamMessage(stream: channel)]);
       check(controller).isA<StreamComposeBoxController>()
         ..topicFocusNode.hasFocus.isFalse()
@@ -171,7 +171,7 @@ void main() {
       final channel = eg.stream();
       await prepareComposeBox(tester,
         narrow: ChannelNarrow(channel.streamId),
-        streams: [channel],
+        subscriptions: [eg.subscription(channel)],
         messages: []);
       check(controller).isA<StreamComposeBoxController>()
         .topicFocusNode.hasFocus.isTrue();
@@ -181,7 +181,7 @@ void main() {
       final channel = eg.stream();
       await prepareComposeBox(tester,
         narrow: TopicNarrow(channel.streamId, eg.t('topic')),
-        streams: [channel],
+        subscriptions: [eg.subscription(channel)],
         messages: [eg.streamMessage(stream: channel, topic: 'topic')]);
       check(controller).isNotNull().contentFocusNode.hasFocus.isFalse();
     });
@@ -190,7 +190,7 @@ void main() {
       final channel = eg.stream();
       await prepareComposeBox(tester,
         narrow: TopicNarrow(channel.streamId, eg.t('topic')),
-        streams: [channel],
+        subscriptions: [eg.subscription(channel)],
         messages: []);
       check(controller).isNotNull().contentFocusNode.hasFocus.isTrue();
     });
@@ -379,7 +379,7 @@ void main() {
         addTearDown(MessageStoreImpl.debugReset);
 
         final narrow = ChannelNarrow(channel.streamId);
-        await prepareComposeBox(tester, narrow: narrow, streams: [channel]);
+        await prepareComposeBox(tester, narrow: narrow, subscriptions: [eg.subscription(channel)]);
         await enterTopic(tester, narrow: narrow, topic: 'some topic');
         await enterContent(tester, content);
       }
@@ -418,7 +418,7 @@ void main() {
         addTearDown(MessageStoreImpl.debugReset);
 
         final narrow = ChannelNarrow(channel.streamId);
-        await prepareComposeBox(tester, narrow: narrow, streams: [channel]);
+        await prepareComposeBox(tester, narrow: narrow, subscriptions: [eg.subscription(channel)]);
         await enterTopic(tester, narrow: narrow, topic: topic);
         await enterContent(tester, 'some content');
       }
@@ -462,7 +462,7 @@ void main() {
       await prepareComposeBox(tester,
         narrow: narrow,
         otherUsers: [eg.otherUser, eg.thirdUser],
-        streams: [channel],
+        subscriptions: [eg.subscription(channel)],
         mandatoryTopics: mandatoryTopics,
         zulipFeatureLevel: zulipFeatureLevel);
     }
@@ -736,14 +736,14 @@ void main() {
     testWidgets('_StreamComposeBox', (tester) async {
       final channel = eg.stream();
       await prepareComposeBox(tester,
-        narrow: ChannelNarrow(channel.streamId), streams: [channel]);
+        narrow: ChannelNarrow(channel.streamId), subscriptions: [eg.subscription(channel)]);
       checkComposeBoxTextFields(tester, expectTopicTextField: true);
     });
 
     testWidgets('_FixedDestinationComposeBox', (tester) async {
       final channel = eg.stream();
       await prepareComposeBox(tester,
-        narrow: eg.topicNarrow(channel.streamId, 'topic'), streams: [channel]);
+        narrow: eg.topicNarrow(channel.streamId, 'topic'), subscriptions: [eg.subscription(channel)]);
       checkComposeBoxTextFields(tester, expectTopicTextField: false);
     });
   });
@@ -762,7 +762,8 @@ void main() {
     }
 
     testWidgets('smoke TopicNarrow', (tester) async {
-      await prepareComposeBox(tester, narrow: narrow, streams: [channel]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(channel)]);
 
       await checkStartTyping(tester, narrow);
 
@@ -786,7 +787,8 @@ void main() {
     testWidgets('smoke ChannelNarrow', (tester) async {
       final narrow = ChannelNarrow(channel.streamId);
       final destinationNarrow = eg.topicNarrow(narrow.streamId, 'test topic');
-      await prepareComposeBox(tester, narrow: narrow, streams: [channel]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(channel)]);
       await enterTopic(tester, narrow: narrow, topic: 'test topic');
 
       await checkStartTyping(tester, destinationNarrow);
@@ -797,7 +799,8 @@ void main() {
     });
 
     testWidgets('clearing text sends a "typing stopped" notice', (tester) async {
-      await prepareComposeBox(tester, narrow: narrow, streams: [channel]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(channel)]);
 
       await checkStartTyping(tester, narrow);
 
@@ -809,7 +812,8 @@ void main() {
     testWidgets('hitting send button sends a "typing stopped" notice', (tester) async {
       MessageStoreImpl.debugOutboxEnable = false;
       addTearDown(MessageStoreImpl.debugReset);
-      await prepareComposeBox(tester, narrow: narrow, streams: [channel]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(channel)]);
 
       await checkStartTyping(tester, narrow);
 
@@ -855,7 +859,8 @@ void main() {
     testWidgets('for content input, unfocusing sends a "typing stopped" notice', (tester) async {
       final narrow = ChannelNarrow(channel.streamId);
       final destinationNarrow = eg.topicNarrow(narrow.streamId, 'test topic');
-      await prepareComposeBox(tester, narrow: narrow, streams: [channel]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(channel)]);
       await enterTopic(tester, narrow: narrow, topic: 'test topic');
 
       await checkStartTyping(tester, destinationNarrow);
@@ -867,7 +872,8 @@ void main() {
     });
 
     testWidgets('selection change sends a "typing started" notice', (tester) async {
-      await prepareComposeBox(tester, narrow: narrow, streams: [channel]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(channel)]);
 
       await checkStartTyping(tester, narrow);
 
@@ -887,7 +893,8 @@ void main() {
     });
 
     testWidgets('unfocusing app sends a "typing stopped" notice', (tester) async {
-      await prepareComposeBox(tester, narrow: narrow, streams: [channel]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(channel)]);
 
       await checkStartTyping(tester, narrow);
 
@@ -919,8 +926,9 @@ void main() {
       addTearDown(MessageStoreImpl.debugReset);
 
       final zulipLocalizations = GlobalLocalizations.zulipLocalizations;
-      await prepareComposeBox(tester, narrow: eg.topicNarrow(123, 'some topic'),
-        streams: [eg.stream(streamId: 123)]);
+      await prepareComposeBox(tester,
+        narrow: eg.topicNarrow(123, 'some topic'),
+        subscriptions: [eg.subscription(eg.stream(streamId: 123))]);
 
       await enterContent(tester, 'hello world');
 
@@ -977,7 +985,7 @@ void main() {
       channel = eg.stream();
       final narrow = ChannelNarrow(channel.streamId);
       await prepareComposeBox(tester,
-        narrow: narrow, streams: [channel],
+        narrow: narrow, subscriptions: [eg.subscription(channel)],
         mandatoryTopics: mandatoryTopics,
         zulipFeatureLevel: zulipFeatureLevel);
 
@@ -1057,7 +1065,8 @@ void main() {
 
       final channel = eg.stream();
       final narrow = ChannelNarrow(channel.streamId);
-      await prepareComposeBox(tester, narrow: narrow, streams: [channel]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(channel)]);
 
       // (When we check that the send button looks disabled, it should be because
       // the file is uploading, not a pre-existing reason.)
@@ -1175,7 +1184,8 @@ void main() {
 
       final channel = eg.stream();
       final narrow = eg.topicNarrow(channel.streamId, 'a topic');
-      await prepareComposeBox(tester, narrow: narrow, streams: [channel]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(channel)]);
 
       testBinding.pickFilesResult = FilePickerResult([PlatformFile(
         readStream: Stream.fromIterable(['asdf'.codeUnits]),
@@ -1631,7 +1641,8 @@ void main() {
     }
 
     testWidgets('normal text scale factor', (tester) async {
-      await prepareComposeBox(tester, narrow: narrow, streams: [stream]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(stream)]);
 
       await checkContentInputMaxHeight(tester,
         maxHeight: verticalPadding + 170, maxVisibleLines: 8);
@@ -1640,23 +1651,26 @@ void main() {
     testWidgets('lower text scale factor', (tester) async {
       tester.platformDispatcher.textScaleFactorTestValue = 0.8;
       addTearDown(tester.platformDispatcher.clearTextScaleFactorTestValue);
-      await prepareComposeBox(tester, narrow: narrow, streams: [stream]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(stream)]);
       await checkContentInputMaxHeight(tester,
         maxHeight: verticalPadding + 170 * 0.8, maxVisibleLines: 8);
     });
 
     testWidgets('higher text scale factor', (tester) async {
       tester.platformDispatcher.textScaleFactorTestValue = 1.5;
       addTearDown(tester.platformDispatcher.clearTextScaleFactorTestValue);
-      await prepareComposeBox(tester, narrow: narrow, streams: [stream]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(stream)]);
       await checkContentInputMaxHeight(tester,
         maxHeight: verticalPadding + 170 * 1.5, maxVisibleLines: 8);
     });
 
     testWidgets('higher text scale factor exceeding threshold', (tester) async {
       tester.platformDispatcher.textScaleFactorTestValue = 2;
       addTearDown(tester.platformDispatcher.clearTextScaleFactorTestValue);
-      await prepareComposeBox(tester, narrow: narrow, streams: [stream]);
+      await prepareComposeBox(tester,
+        narrow: narrow, subscriptions: [eg.subscription(stream)]);
       await checkContentInputMaxHeight(tester,
         maxHeight: verticalPadding + 170 * 1.5, maxVisibleLines: 6);
     });
@@ -1671,7 +1685,8 @@ void main() {
 
       final channel = eg.stream();
       await prepareComposeBox(tester,
-        narrow: eg.topicNarrow(channel.streamId, 'topic'), streams: [channel]);
+        narrow: eg.topicNarrow(channel.streamId, 'topic'),
+        subscriptions: [eg.subscription(channel)]);
 
       await enterContent(tester, 'some content');
       checkContentInputValue(tester, 'some content');
@@ -1769,7 +1784,9 @@ void main() {
       TypingNotifier.debugEnable = false;
       addTearDown(TypingNotifier.debugReset);
       await prepareComposeBox(tester,
-        narrow: narrow, streams: [channel], otherUsers: otherUsers);
+        narrow: narrow,
+        subscriptions: [eg.subscription(channel)],
+        otherUsers: otherUsers);
 
       if (narrow is ChannelNarrow) {
         connection.prepare(json: GetStreamTopicsResult(topics: []).toJson());
@@ -1937,7 +1954,7 @@ void main() {
       addTearDown(MessageStoreImpl.debugReset);
       await prepareComposeBox(tester,
         narrow: narrow,
-        streams: [channel]);
+        subscriptions: [eg.subscription(channel)]);
       await store.addMessages([message, dmMessage]);
       await tester.pump(); // message list updates
     }