Skip to content

Commit 630caee

Browse files
chrisbobbegnprice
authored andcommitted
settings: For subtitle of selected language, repeat canonical self-name
It looks odd to have an item where the title and subtitle are slightly different ways of naming the same thing. The canonical self-name is the one we've chosen by following organizations with a broad global contributor base like Wikipedia, so use that. (We could instead just omit the subtitle, but if we did, then all the rows in the list would have two lines of text except the selected row which would have just one. And that non-uniformity might look odd.)
1 parent eba3566 commit 630caee

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/settings/SettingsScreen.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export default function SettingsScreen(props: Props): Node {
135135
items={languages.map(l => ({
136136
key: l.tag,
137137
title: noTranslation(l.selfname),
138-
subtitle: l.name,
138+
subtitle: l.tag === language ? noTranslation(l.selfname) : l.name,
139139
}))}
140140
onValueChange={value => {
141141
dispatch(setGlobalSettings({ language: value }));

0 commit comments

Comments
 (0)