Test for 'false' database value when not found in DSN

Author: Iskandar Najmuddin

lib/Resque/Redis.php

@@ -109,7 +109,8 @@ public static function prefix($namespace)
 
 	/**
 	 * @param string|array $server A DSN or array
-	 * @param int $database A database number to select
+	 * @param int $database A database number to select. However, if we find a valid database number in the DSN the
+	 *                      DSN-supplied value will be used instead and this parameter is ignored.
 	 */
     public function __construct($server, $database = null)
 	{
@@ -134,7 +135,7 @@ public function __construct($server, $database = null)
 			}
 
 			// If we have found a database in our DSN, use it instead of the `$database`
-			// value passed into the constructor
+			// value passed into the constructor.
 			if ($dsnDatabase !== false) {
 				$database = $dsnDatabase;
 				$this->database = $database;

test/Resque/Tests/DsnTest.php

@@ -21,21 +21,21 @@ public function validDsnStringProvider()
 			array('', array(
 				'localhost',
 				Resque_Redis::DEFAULT_PORT,
-				Resque_Redis::DEFAULT_DATABASE,
+				false,
 				false, false,
 				array(),
 			)),
 			array('localhost', array(
 				'localhost',
 				Resque_Redis::DEFAULT_PORT,
-				Resque_Redis::DEFAULT_DATABASE,
+				false,
 				false, false,
 				array(),
 			)),
 			array('localhost:1234', array(
 				'localhost',
 				1234,
-				Resque_Redis::DEFAULT_DATABASE,
+				false,
 				false, false,
 				array(),
 			)),
@@ -49,14 +49,14 @@ public function validDsnStringProvider()
 			array('redis://foobar', array(
 				'foobar',
 				Resque_Redis::DEFAULT_PORT,
-				Resque_Redis::DEFAULT_DATABASE,
+				false,
 				false, false,
 				array(),
 			)),
 			array('redis://foobar:1234', array(
 				'foobar',
 				1234,
-				Resque_Redis::DEFAULT_DATABASE,
+				false,
 				false, false,
 				array(),
 			)),
@@ -67,10 +67,17 @@ public function validDsnStringProvider()
 				false, false,
 				array(),
 			)),
+			array('redis://foobar:1234/0', array(
+				'foobar',
+				1234,
+				0,
+				false, false,
+				array(),
+			)),
 			array('redis://user@foobar:1234', array(
 				'foobar',
 				1234,
-				Resque_Redis::DEFAULT_DATABASE,
+				false,
 				'user', false,
 				array(),
 			)),
@@ -84,35 +91,35 @@ public function validDsnStringProvider()
 			array('redis://user:pass@foobar:1234', array(
 				'foobar',
 				1234,
-				Resque_Redis::DEFAULT_DATABASE,
+				false,
 				'user', 'pass',
 				array(),
 			)),
 			array('redis://user:pass@foobar:1234?x=y&a=b', array(
 				'foobar',
 				1234,
-				Resque_Redis::DEFAULT_DATABASE,
+				false,
 				'user', 'pass',
 				array('x' => 'y', 'a' => 'b'),
 			)),
 			array('redis://:pass@foobar:1234?x=y&a=b', array(
 				'foobar',
 				1234,
-				Resque_Redis::DEFAULT_DATABASE,
+				false,
 				false, 'pass',
 				array('x' => 'y', 'a' => 'b'),
 			)),
 			array('redis://user@foobar:1234?x=y&a=b', array(
 				'foobar',
 				1234,
-				Resque_Redis::DEFAULT_DATABASE,
+				false,
 				'user', false,
 				array('x' => 'y', 'a' => 'b'),
 			)),
 			array('redis://foobar:1234?x=y&a=b', array(
 				'foobar',
 				1234,
-				Resque_Redis::DEFAULT_DATABASE,
+				false,
 				false, false,
 				array('x' => 'y', 'a' => 'b'),
 			)),