Most tests passing

Author: chriscarrollsmith

src/server/TaskManager.ts

@@ -232,18 +232,23 @@ export class TaskManager {
       });
       return await this.createProject(prompt, object.tasks, object.projectPlan);
     } catch (err: any) {
-      // Handle specific error cases
-      if (err.name === 'LoadAPIKeyError' || err.message.includes('API key is missing')) {
+      if (err.name === 'LoadAPIKeyError' || 
+          err.message.includes('API key is missing') || 
+          err.message.includes('You didn\'t provide an API key') ||
+          err.message.includes('unregistered callers') ||
+          (err.responseBody && err.responseBody.includes('Authentication Fails'))) {
         throw new AppError(
-          "Invalid or missing API key. Please check your environment variables.",
-          AppErrorCode.LLMConfigurationError,
+          `Missing API key environment variable required for ${provider}`,
+          AppErrorCode.ConfigurationError,
           err
         );
       }
-      if (err.message.includes('authentication') || err.message.includes('unauthorized')) {
+      // Check for invalid model errors by looking at the error code, type, and message
+      if ((err.data?.error?.code === 'model_not_found') && 
+          err.message.includes('model')) {
         throw new AppError(
-          "Authentication failed with the LLM provider. Please check your credentials.",
-          AppErrorCode.LLMConfigurationError,
+          `Invalid model: ${model} is not available for ${provider}`,
+          AppErrorCode.InvalidModel,
           err
         );
       }
@@ -584,6 +589,7 @@ export class TaskManager {
       initialPrompt: project.initialPrompt,
       projectPlan: project.projectPlan,
       completed: project.completed,
+      autoApprove: project.autoApprove,
       tasks: project.tasks,
     };
   }

src/server/toolExecutors.ts

@@ -190,23 +190,6 @@ const generateProjectPlanToolExecutor: ToolExecutor = {
     const provider = validateRequiredStringParam(args.provider, "provider");
     const model = validateRequiredStringParam(args.model, "model");
 
-    // Validate provider is one of the allowed values
-    if (!["openai", "google", "deepseek"].includes(provider)) {
-      throw new AppError(
-        `Invalid provider: ${provider}. Must be one of: openai, google, deepseek`,
-        AppErrorCode.InvalidArgument
-      );
-    }
-
-    // Check that the corresponding API key is set
-    const envKey = provider === "google" ? "GOOGLE_GENERATIVE_AI_API_KEY" : `${provider.toUpperCase()}_API_KEY`;
-    if (!process.env[envKey]) {
-      throw new AppError(
-        `Missing ${envKey} environment variable required for ${provider}`,
-        AppErrorCode.ConfigurationError
-      );
-    }
-
     // Validate optional attachments
     let attachments: string[] = [];
     if (args.attachments !== undefined) {

src/types/errors.ts

@@ -2,14 +2,15 @@
 export enum AppErrorCode {
     // Protocol Errors (ERR_1xxx)
     MissingParameter = 'ERR_1000', // General missing param (mapped to protocol -32602)
-    InvalidArgument = 'ERR_1002', // Extra / invalid param (mapped to protocol -32602)
+    InvalidArgument = 'ERR_1002', // Extra param / invalid type (mapped to protocol -32602)
 
     // Validation / Resource Not Found (ERR_2xxx)
     ConfigurationError = 'ERR_2000', // e.g., Missing API Key for generate_project_plan
     ProjectNotFound = 'ERR_2001',
     TaskNotFound = 'ERR_2002',
     InvalidState = 'ERR_2003', // e.g., invalid state filter
     InvalidProvider = 'ERR_2004', // e.g., invalid model provider
+    InvalidModel = 'ERR_2005', // e.g., invalid model name or model not accessible
 
     // No need for EmptyTaskFile code, handle during load
 

src/types/response.ts

@@ -61,6 +61,7 @@ export interface ProjectCreationSuccessData {
     initialPrompt: string;
     projectPlan: string;
     completed: boolean;
+    autoApprove?: boolean;
     tasks: Task[];
   }
 

tests/mcp/test-helpers.ts

@@ -24,7 +24,11 @@ export interface TestContext {
 /**
  * Sets up a test context with MCP client, transport, and temp directory
  */
-export async function setupTestContext(customFilePath?: string, skipFileInit: boolean = false): Promise<TestContext> {
+export async function setupTestContext(
+  customFilePath?: string,
+  skipFileInit: boolean = false,
+  customEnv?: Record<string, string>
+): Promise<TestContext> {
   // Create a unique temp directory for test
   const tempDir = path.join(os.tmpdir(), `mcp-client-integration-test-${Date.now()}-${Math.floor(Math.random() * 10000)}`);
   await fs.mkdir(tempDir, { recursive: true });
@@ -46,9 +50,12 @@ export async function setupTestContext(customFilePath?: string, skipFileInit: bo
       TASK_MANAGER_FILE_PATH: testFilePath,
       NODE_ENV: "test",
       DEBUG: "mcp:*",  // Enable MCP debug logging
-      // Pass API keys from the test runner's env to the child process env
-      OPENAI_API_KEY: process.env.OPENAI_API_KEY ?? '',
-      GOOGLE_GENERATIVE_AI_API_KEY: process.env.GOOGLE_GENERATIVE_AI_API_KEY ?? ''
+      // Use custom env if provided, otherwise use default API keys
+      ...(customEnv || {
+        OPENAI_API_KEY: process.env.OPENAI_API_KEY ?? '',
+        GOOGLE_GENERATIVE_AI_API_KEY: process.env.GOOGLE_GENERATIVE_AI_API_KEY ?? '',
+        DEEPSEEK_API_KEY: process.env.DEEPSEEK_API_KEY ?? ''
+      })
     }
   });