Passing live API tests

Author: chriscarrollsmith

README.md

@@ -40,14 +40,14 @@ This will show the available commands and options.
 The task manager supports multiple LLM providers for generating project plans. You can configure one or more of the following environment variables depending on which providers you want to use:
 
 - `OPENAI_API_KEY`: Required for using OpenAI models (e.g., GPT-4)
-- `GEMINI_API_KEY`: Required for using Google's Gemini models
+- `GOOGLE_GENERATIVE_AI_API_KEY`: Required for using Google's Gemini models
 - `DEEPSEEK_API_KEY`: Required for using Deepseek models
 
 To generate project plans using the CLI, set these environment variables in your shell:
 
 ```bash
 export OPENAI_API_KEY="your-api-key"
-export GEMINI_API_KEY="your-api-key"
+export GOOGLE_GENERATIVE_AI_API_KEY="your-api-key"
 export DEEPSEEK_API_KEY="your-api-key"
 ```
 
@@ -61,7 +61,7 @@ Or you can include them in your MCP client configuration to generate project pla
       "args": ["-y", "taskqueue-mcp"],
       "env": {
         "OPENAI_API_KEY": "your-api-key",
-        "GEMINI_API_KEY": "your-api-key",
+        "GOOGLE_GENERATIVE_AI_API_KEY": "your-api-key",
         "DEEPSEEK_API_KEY": "your-api-key"
       }
     }

package-lock.json

@@ -55,6 +55,7 @@
 		"@types/jest": "^29.5.12",
 		"@types/json-schema": "^7.0.15",
 		"@types/node": "^20.11.0",
+		"dotenv": "^16.4.7",
 		"jest": "^29.7.0",
 		"shx": "^0.3.4",
 		"ts-jest": "^29.1.2",

package.json

@@ -344,7 +344,8 @@ program
 
             // Fetch tasks for this project, applying state filter
             const tasksResponse = await taskManager.listTasks(projectId, filterState);
-            const tasks = tasksResponse.data?.tasks || [];
+            // Check for success before accessing data
+            const tasks = tasksResponse.status === 'success' ? tasksResponse.data.tasks : [];
 
             console.log(chalk.cyan(`\n📋 Project ${chalk.bold(projectId)} details:`));
             console.log(`  - ${chalk.bold('Initial Prompt:')} ${project.initialPrompt}`);
@@ -428,7 +429,8 @@ program
       } else {
         // List all projects, applying state filter
         const projectsResponse = await taskManager.listProjects(filterState);
-        const projectsToList = projectsResponse.data?.projects || [];
+        // Check for success before accessing data
+        const projectsToList = projectsResponse.status === 'success' ? projectsResponse.data.projects : [];
 
         if (projectsToList.length === 0) {
           console.log(chalk.yellow(`No projects found${filterState ? ` matching state '${filterState}'` : ''}.`));

src/client/cli.ts

@@ -1,5 +1,21 @@
 import * as path from "node:path";
-import { Task, TaskManagerFile, TaskState, StandardResponse, ErrorCode, Project } from "../types/index.js";
+import {
+  Task,
+  TaskManagerFile,
+  TaskState,
+  StandardResponse,
+  ErrorCode,
+  Project,
+  ProjectCreationSuccessData,
+  ApproveTaskSuccessData,
+  ApproveProjectSuccessData,
+  OpenTaskSuccessData,
+  ListProjectsSuccessData,
+  ListTasksSuccessData,
+  AddTasksSuccessData,
+  DeleteTaskSuccessData,
+  ReadProjectSuccessData
+} from "../types/index.js";
 import { createError, createSuccessResponse } from "../utils/errors.js";
 import { generateObject, jsonSchema } from "ai";
 import { formatTaskProgressTable, formatProjectsList } from "./taskFormattingUtils.js";
@@ -54,7 +70,7 @@ export class TaskManager {
     tasks: { title: string; description: string; toolRecommendations?: string; ruleRecommendations?: string }[],
     projectPlan?: string,
     autoApprove?: boolean
-  ) {
+  ): Promise<StandardResponse<ProjectCreationSuccessData>> {
     await this.ensureInitialized();
     // Reload before creating to ensure counters are up-to-date
     await this.reloadFromDisk();
@@ -113,7 +129,7 @@ export class TaskManager {
     provider: string;
     model: string;
     attachments: string[];
-  }): Promise<StandardResponse> {
+  }): Promise<StandardResponse<ProjectCreationSuccessData>> {
     await this.ensureInitialized();
 
     // Wrap prompt and attachments in XML tags
@@ -283,7 +299,7 @@ export class TaskManager {
     };
   }
 
-  public async approveTaskCompletion(projectId: string, taskId: string) {
+  public async approveTaskCompletion(projectId: string, taskId: string): Promise<StandardResponse<ApproveTaskSuccessData>> {
     await this.ensureInitialized();
     // Reload before modifying
     await this.reloadFromDisk();
@@ -308,7 +324,18 @@ export class TaskManager {
       );
     }
     if (task.approved) {
-      return createSuccessResponse({ message: "Task already approved." });
+      // Return the full expected data structure even if already approved
+      return createSuccessResponse({
+        message: "Task already approved.",
+        projectId: proj.projectId,
+        task: {
+          id: task.id,
+          title: task.title,
+          description: task.description,
+          completedDetails: task.completedDetails,
+          approved: task.approved,
+        },
+      });
     }
 
     task.approved = true;
@@ -325,7 +352,7 @@ export class TaskManager {
     });
   }
 
-  public async approveProjectCompletion(projectId: string) {
+  public async approveProjectCompletion(projectId: string): Promise<StandardResponse<ApproveProjectSuccessData>> {
     await this.ensureInitialized();
     // Reload before modifying
     await this.reloadFromDisk();
@@ -369,7 +396,7 @@ export class TaskManager {
     });
   }
 
-  public async openTaskDetails(taskId: string) {
+  public async openTaskDetails(taskId: string): Promise<StandardResponse<OpenTaskSuccessData>> {
     await this.ensureInitialized();
     // Reload from disk to ensure we have the latest data
     await this.reloadFromDisk();
@@ -399,7 +426,7 @@ export class TaskManager {
     );
   }
 
-  public async listProjects(state?: TaskState) {
+  public async listProjects(state?: TaskState): Promise<StandardResponse<ListProjectsSuccessData>> {
     await this.ensureInitialized();
     // Reload from disk to ensure we have the latest data
     await this.reloadFromDisk();
@@ -434,7 +461,7 @@ export class TaskManager {
     });
   }
 
-  public async listTasks(projectId?: string, state?: TaskState) {
+  public async listTasks(projectId?: string, state?: TaskState): Promise<StandardResponse<ListTasksSuccessData>> {
     await this.ensureInitialized();
     // Reload from disk to ensure we have the latest data
     await this.reloadFromDisk();
@@ -489,7 +516,7 @@ export class TaskManager {
   public async addTasksToProject(
     projectId: string,
     tasks: { title: string; description: string; toolRecommendations?: string; ruleRecommendations?: string }[]
-  ) {
+  ): Promise<StandardResponse<AddTasksSuccessData>> {
     await this.ensureInitialized();
     // Reload before modifying
     await this.reloadFromDisk();
@@ -541,7 +568,7 @@ export class TaskManager {
       status?: "not started" | "in progress" | "done";
       completedDetails?: string;
     }
-  ) {
+  ): Promise<StandardResponse<Task>> {
     await this.ensureInitialized();
     // Reload before modifying
     await this.reloadFromDisk();
@@ -573,7 +600,7 @@ export class TaskManager {
     return createSuccessResponse(project.tasks[taskIndex]);
   }
 
-  public async deleteTask(projectId: string, taskId: string) {
+  public async deleteTask(projectId: string, taskId: string): Promise<StandardResponse<DeleteTaskSuccessData>> {
     await this.ensureInitialized();
     // Reload before modifying
     await this.reloadFromDisk();
@@ -608,13 +635,7 @@ export class TaskManager {
     });
   }
 
-  public async readProject(projectId: string): Promise<StandardResponse<{
-    projectId: string;
-    initialPrompt: string;
-    projectPlan: string;
-    completed: boolean;
-    tasks: Task[];
-  }>> {
+  public async readProject(projectId: string): Promise<StandardResponse<ReadProjectSuccessData>> {
     await this.ensureInitialized();
     // Reload from disk to ensure we have the latest data
     await this.reloadFromDisk();

src/server/TaskManager.ts

@@ -83,6 +83,75 @@ export interface StandardError {
   details?: unknown;
 }
 
+// Define the structure for createProject success data
+export interface ProjectCreationSuccessData {
+  projectId: string;
+  totalTasks: number;
+  tasks: Array<{ id: string; title: string; description: string }>;
+  message: string;
+}
+
+// --- NEW Success Data Interfaces ---
+
+export interface ApproveTaskSuccessData {
+  projectId: string;
+  task: {
+    id: string;
+    title: string;
+    description: string;
+    completedDetails: string;
+    approved: boolean;
+  };
+}
+
+export interface ApproveProjectSuccessData {
+  projectId: string;
+  message: string;
+}
+
+export interface OpenTaskSuccessData {
+  projectId: string;
+  initialPrompt: string;
+  projectPlan: string;
+  completed: boolean;
+  task: Task; // Use the full Task type
+}
+
+export interface ListProjectsSuccessData {
+  message: string;
+  projects: Array<{
+    projectId: string;
+    initialPrompt: string;
+    totalTasks: number;
+    completedTasks: number;
+    approvedTasks: number;
+  }>;
+}
+
+export interface ListTasksSuccessData {
+  message: string;
+  tasks: Task[]; // Use the full Task type
+}
+
+export interface AddTasksSuccessData {
+  message: string;
+  newTasks: Array<{ id: string; title: string; description: string }>;
+}
+
+export interface DeleteTaskSuccessData {
+  message: string;
+}
+
+export interface ReadProjectSuccessData {
+  projectId: string;
+  initialPrompt: string;
+  projectPlan: string;
+  completed: boolean;
+  tasks: Task[]; // Use the full Task type
+}
+
+// --- End NEW Success Data Interfaces ---
+
 // Generic success response
 export interface SuccessResponse<T = unknown> {
   status: "success";