Code simplification, deduplication

Author: chriscarrollsmith

README.md

@@ -1,6 +1,6 @@
 # MCP Task Manager
 
-A Model Context Protocol (MCP) server for AI task management. This tool helps AI assistants handle multi-step tasks in a structured way, with user approval checkpoints.
+  MCP Task Manager ([npm package: taskqueue-mcp](https://www.npmjs.com/package/taskqueue-mcp)) is a Model Context Protocol (MCP) server for AI task management. This tool helps AI assistants handle multi-step tasks in a structured way, with optional user approval checkpoints.
 
 ## Features
 

index.ts

@@ -178,40 +178,19 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
           throw new Error("Missing required parameters: projectId and/or taskId");
         }
 
-        const updates: { title?: string; description?: string } = {};
-        if (args.title !== undefined) updates.title = String(args.title);
-        if (args.description !== undefined) updates.description = String(args.description);
-        
+        const updates = Object.fromEntries(
+          Object.entries({
+            title: args.title !== undefined ? String(args.title) : undefined,
+            description: args.description !== undefined ? String(args.description) : undefined,
+            status: args.status !== undefined ? String(args.status) as "not started" | "in progress" | "done" : undefined,
+            completedDetails: args.completedDetails !== undefined ? String(args.completedDetails) : undefined,
+            toolRecommendations: args.toolRecommendations !== undefined ? String(args.toolRecommendations) : undefined,
+            ruleRecommendations: args.ruleRecommendations !== undefined ? String(args.ruleRecommendations) : undefined
+          }).filter(([_, value]) => value !== undefined)
+        );
+
         const result = await taskManager.updateTask(projectId, taskId, updates);
-        
-        // Handle status change separately if needed
-        if (args.status) {
-          const status = args.status as "not started" | "in progress" | "done";
-          const proj = taskManager["data"].projects.find(p => p.projectId === projectId);
-          if (proj) {
-            const task = proj.tasks.find(t => t.id === taskId);
-            if (task) {
-              if (status === "done") {
-                if (!args.completedDetails) {
-                  return {
-                    content: [{ type: "text", text: JSON.stringify({
-                      status: "error",
-                      message: "completedDetails is required when setting status to 'done'"
-                    }, null, 2) }],
-                  };
-                }
-                
-                // Use markTaskDone for proper transition to done status
-                await taskManager.markTaskDone(projectId, taskId, String(args.completedDetails));
-              } else {
-                // For other status changes
-                task.status = status;
-                await taskManager["saveTasks"]();
-              }
-            }
-          }
-        }
-        
+
         return {
           content: [{ type: "text", text: JSON.stringify(result, null, 2) }],
         };

jest.config.cjs

@@ -14,4 +14,10 @@ module.exports = {
     ],
   },
   modulePathIgnorePatterns: ['<rootDir>/dist/'],
+  // Force Jest to exit after all tests have completed
+  forceExit: true,
+  // Detect open handles and warn about them
+  detectOpenHandles: true,
+  // Extend the timeout to allow sufficient time for tests to complete
+  testTimeout: 30000,
 }; 

src/server/TaskManager.ts

@@ -129,7 +129,8 @@ export class TaskManager {
   public async createProject(
     initialPrompt: string,
     tasks: { title: string; description: string; toolRecommendations?: string; ruleRecommendations?: string }[],
-    projectPlan?: string
+    projectPlan?: string,
+    autoApprove?: boolean
   ) {
     await this.ensureInitialized();
     this.projectCounter += 1;
@@ -156,6 +157,7 @@ export class TaskManager {
       projectPlan: projectPlan || initialPrompt,
       tasks: newTasks,
       completed: false,
+      autoApprove: autoApprove === true ? true : false,
     });
 
     await this.saveTasks();
@@ -213,38 +215,6 @@ export class TaskManager {
     };
   }
 
-  public async markTaskDone(
-    projectId: string,
-    taskId: string,
-    completedDetails?: string
-  ) {
-    await this.ensureInitialized();
-    const proj = this.data.projects.find((p) => p.projectId === projectId);
-    if (!proj) return { status: "error", message: "Project not found" };
-    const task = proj.tasks.find((t) => t.id === taskId);
-    if (!task) return { status: "error", message: "Task not found" };
-    if (task.status === "done")
-      return {
-        status: "already_done",
-        message: "Task is already marked done.",
-      };
-
-    task.status = "done";
-    task.completedDetails = completedDetails || "";
-    await this.saveTasks();
-    return {
-      status: "task_marked_done",
-      projectId: proj.projectId,
-      task: {
-        id: task.id,
-        title: task.title,
-        description: task.description,
-        completedDetails: task.completedDetails,
-        approved: task.approved,
-      },
-    };
-  }
-
   public async approveTaskCompletion(projectId: string, taskId: string) {
     await this.ensureInitialized();
     const proj = this.data.projects.find((p) => p.projectId === projectId);
@@ -457,6 +427,8 @@ export class TaskManager {
       description?: string;
       toolRecommendations?: string;
       ruleRecommendations?: string;
+      status?: "not started" | "in progress" | "done";
+      completedDetails?: string;
     }
   ) {
     await this.ensureInitialized();
@@ -473,6 +445,11 @@ export class TaskManager {
     // Update the task with the provided updates
     project.tasks[taskIndex] = { ...project.tasks[taskIndex], ...updates };
 
+    // Check if status was updated to 'done' and if project has autoApprove enabled
+    if (updates.status === 'done' && project.autoApprove) {
+      project.tasks[taskIndex].approved = true;
+    }
+
     await this.saveTasks();
     return project.tasks[taskIndex];
   }

src/server/tools.ts

@@ -76,6 +76,10 @@ const createProjectTool: Tool = {
           required: ["title", "description"],
         },
       },
+      autoApprove: {
+        type: "boolean",
+        description: "If true, tasks will be automatically approved when marked as done. If false or not provided, tasks require manual approval.",
+      },
     },
     required: ["initialPrompt", "tasks"],
   },

src/types/index.ts

@@ -18,6 +18,7 @@ export interface Project {
   projectPlan: string;
   tasks: Task[];
   completed: boolean;
+  autoApprove?: boolean;
 }
 
 export interface TaskManagerFile {