Single column view stable (edit: merged)

[chrisgoringe]

I've pulled all the 0.9.9 stuff onto a new branch which is single column only. The branch is single_column.

The list of issues that I believe are now resolved can be found here https://github.com/chrisgoringe/cg-controller/milestone/20

If you try it out, please add a comment to anything which works for you, as well as anything that doesn't!

I'm going to leave this for 24-48 hours (real life intrudes) and will then read through all comments on all those issues!

[JorgeR81]

I like it.

I made some sugestions:
#146
#145

---

But I think I could be worth exploring another variant of single-column:

Just add it to the Sidebar !

Reasons:

• The free space below the Controller would probably be useless, unless you have a very small Controller.
  I will probably use it full size all the time.

• The Sidebar partially hides the Controller, which looks ugly.

• The new controller button could be placed as an icon in the sidebar.
  This would look better and save space in the topbar ( which can be used for more workflow tabs ).

[LukeG89]

I was asking myself the same thing. The other sidebar windows are covering the Controller anyway, so making it as a sidebar tab could be a good idea.

[LukeG89]

I don't know @chrisgoringe, with the single column now I feel very "restricted" and scrolling up and down doesn't seem convenient.
Maybe a single column would be enough when you only have a few Controllers, or for people that want to keep a clear view of the canvas, but in many other scenarios it's pretty limited.

Why not making it optionable?

[JorgeR81]

I also noticed this feature ( #100 ) was moved to the 1.1. milestones !

This could have even more potential than multiple columns. 
With this we can navigate through a workflow with 50 groups or more.
 
We can zoom out the graph, to use it as a "Mini map".
And this feature will "auto select" the group in the Controller, when we click it in the graph canvas.

[chrisgoringe]

Thinking more about this, multi column might be implemented as an option fairly simply with some caveats:

the controller would be fixed height (full height)

Drag and drop reordering might be a little unintuitive when moving between columns

[JorgeR81]

the controller would be fixed height (full height)

But, wouldn't it be full height already with the Sidebar integration ?

Drag and drop reordering might be a little unintuitive when moving between columns

Will we be able to move nodes between columns ?!
I thought each column would be assigned, by the user, to a group.

[chrisgoringe]

the controller would be fixed height (full height)

But, wouldn't it be full height already with the Sidebar integration ?

Yes

Drag and drop reordering might be a little unintuitive when moving between columns

Will we be able to move nodes between columns ?! I thought each column would be assigned, by the user, to a group.

Two separate issues. #123 is for multiple columns with multiple group choice. I'm just talking now about the behaviour when the contents are taller than the screen. Currently we have scrollbar, this would be an option to have multiple columns (like it used to be, but without a lot of the complex code added to handle (a) resizing the controller and (b) dragging and dropping at the end of a column.

[JorgeR81]

OK. Great !

[chrisgoringe]

I did take a quick look at doing that, and I think it's feasible.

Question: all the other things that pop out are the same width. Does it matter if this is wider? I think it needs to be.

I'll also need a good icon for the left hand bar - suggestions welcome!

I'll have a look tomorrow if I get the time :). In the mean time, please do see if the other isseus in https://github.com/chrisgoringe/cg-controller/milestone/20 are working right (I don't think any of them will be touched by this)

[JorgeR81]

Yeah, the sidebar width customization is quite limited.
 
I'm hoping they improve the way it works ( Comfy-Org/ComfyUI_frontend#897 )

Until then, maybe you could make the Controller width independent from the other tabs. 

Now works like this ( with these limitations ) :

• You can change the sidebar width, but it will be the same width for all tabs, until you change it again.
  It's not stored "per tab", ( which does not make sense, since they show different content / images ).

• When you start ComfyUI, the width will be reseted. 
  So you can't even save that single width, I have set the last time.  

[LukeG89]

I'll also need a good icon for the left hand bar

I would suggest something like this:

[JorgeR81]

Does it matter if this is wider? I think it needs to be.

Feature Idea:

If you use a full size widgets ( #140 ) the text would fit better, on a narrow Controller.

And the user could manually set the width ( just by dragging the border ), like on the sidebar tabs.

But unlike the other tabs, the Controller sidebar width would be stored !

[chrisgoringe]

Just pushed to the single column branch. Take a look.

(known issues: hover tooltip not working, keyboard shortcut doesn't update the icons)

[chrisgoringe]

I think I've resolved most or all of the issues raised (or placed them in 1.1 or for consideration buckets).

Will merge into main on Sunday if nothing is blocking.