The 1.1 branch #219
Replies: 8 comments 24 replies
-
I'm alos going to need to slow things down a bit :). Can I encourage you to let people know about the controller? I'd really like to have more sense of how people use it (much as I love building something just for the three of us...) |
Beta Was this translation helpful? Give feedback.
-
We may need the shortcut back, to hide them. I'm planning to stack Controllers vertically and horizontally, to optimize space ( e.g. sliders require less width ). But even if I collapse them all, I still have some Controllers in the middle of the canvas. |
Beta Was this translation helpful? Give feedback.
-
@chrisgoringe I wrote a post for the ComfyUI discussion to both promote and ask for help to test Controller. About the beta installation instructions, tell me if there are more "user-friendly" methods. Hi everyone! It's developed by @chrisgoringe, the same developer of cg-use-everywhere From the initial alpha release, Controller has gradually become a powerful extension with a lot of features, such as:
Here's a quick demo video of 1.0 version! 1.0_Controller_Demo.mp4For the next release we need your help! 📣In the current 1.0 version, Controller is a single sidebar window.
And many other features from previous requests. This is how beta 1.1 looks like: And here's a concept mockup of how Controller could look like (created by @JorgeR81) New feedback and user-experiences are needed for the upcoming releases! 🚀Check the Milestones and see the Roadmap! Check the Discussions for news! Open a Bug report! Propose a Feature request! How to install:Stable releases:You can install and update the main stable version through the Manager. Seach "Comfy Controller" 🔎 Beta releases:Installing using gitAfter you installed the stable release, you can:
Tip After the installation, you can update the current beta branch through the Manager! Important When a new branch is released, copy the new branch name and follow the same procedure to install it. Warning Update the new current branch before testing, it may be not up-to-date. Manual installationIf you don't have git installed, you can:
Tip After the installation, you can update the current beta branch through the Manager! Important When a new branch is released, delete the old folder and follow the same procedure to install it. |
Beta Was this translation helpful? Give feedback.
-
OK, I've fixed a whole bunch of mostly small things, and added a few features that 1.1 needed. #221 I think is fixed, but I've never been able to reproduce so I'm not sure! Anything else critical before I redo the images and docs? |
Beta Was this translation helpful? Give feedback.
-
No, I’ve got main and dev for general consumption.
1.2 is very experimental!
…On Tue, 29 Oct 2024 at 8:56 PM, LukeG89 ***@***.***> wrote:
I wonder if it would be a good idea to change the branch naming
convention, so that the name doesn't change from 1.1 to 1.2 etc..
Perhaps once 1.1 is done, I'll move to just having a main branch and a dev
branch.
@chrisgoringe <https://github.com/chrisgoringe> I see you changed your
mind! 😆
image.png (view on web)
<https://github.com/user-attachments/assets/141641e7-e25f-4994-a2b9-a676db8c7003>
—
Reply to this email directly, view it on GitHub
<#219 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBLMA6BIIANR42NIPAGGFDZ55LTXAVCNFSM6AAAAABQWQOT5WVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMBYGUYTQOI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
Leave 1.2 branch for now, there’s something broken in the settings for
different workflows getting munged. I’ll look tomorrow.
…On Tue, 29 Oct 2024 at 11:11 PM, JorgeR81 ***@***.***> wrote:
OK, I know what makes the right click options disappear. It's not
necessary to restart Comfy to fix it.
Steps to replicate:
- Open an workflow with a controller ( it works )
- Open an workflow without a controller ( it will show a controller
with the panels from the previous workflow )
- Refresh the browser to update
The expected behavior would be to show an empty controller.
But the controller is gone and the right click menu is gone.
------------------------------
How to "fix" :
- Load an workflow with a controller ( the issue remains )
- Refresh the browser ( the issue is "fixed" : now I see the
Controller, and I have the option to add a new Controller )
—
Reply to this email directly, view it on GitHub
<#219 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBLMA2BEWLYFC2YNMU4GY3Z553QBAVCNFSM6AAAAABQWQOT5WVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMBYGY2TCNY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
@chrisgoringe @JorgeR81 Posted the Discussion on ComfyUI: |
Beta Was this translation helpful? Give feedback.
-
The window sizes are not working well in When we open a new workflow, the Controller uses the dimensions from the previous workflow. Should we have an issue for this, or will it be fixed in |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
On the 1.1 branch I've done the things shown in https://github.com/chrisgoringe/cg-controller/milestone/23
With the controller being minimizable, and with multiple controllers coming soon, I decided it made no sense to continue to have the sidebar button to toggle the controller. It's just on, hovering there. You can always minimise it.
The keyboard shortcut is also gone. Perhaps when we have multiple controllers it will come back as 'minimise/expand all controllers'.
The benefit of those changes is that it greatly simplifies the way the controller gets positioned, which is going to be essential for doing anything like tabs or snapping windows (or even multiple controllers).
I may have broken stuff :)
Beta Was this translation helpful? Give feedback.
All reactions