1.2 #232

I'm experiencing issues with resizing, entering/exiting fullscreen and opening/closing console and sidebar windows. Everything affects the Controller windows. Maybe the snapping feature will help in some cases.

I also found these little bugs so far:

When you drag a Controller, the cursor moves away from the window bar
When you refresh, the X is blinking (not the refresh icon)

Edit: bonus bug - Controller windows remain when you open a new blank canvas
Edit2: Toggle button sometimes is ignored when opening/switching workflows (I'm sleepy so I can't understand the reason, sorry! 😆 )

Now it's late, I will test better tomorrow.

@JorgeR81 Have you tried it?

JorgeR81 Oct 29, 2024

I'm experiencing issues with resizing, entering/exiting fullscreen and opening/closing console and sidebar windows. Everything affects the Controller windows. Maybe the snapping feature will help in some cases.

When opening the Sidebar, both controllers are moved. When closing, the controllers return to their places.
This works well. I think it's by design: so that the controllers could be visible.

I had an issue with fullscreen: it placed one Controller on top of the other.
But I was not able to replicate this, after restarting Comfy UI.

Opening the console causes the panels to resize. This way they stay fully visible.
But they stay small after I close the console.
Yes, I think snapping could be a solution for this.

JorgeR81 · 2024-10-29T23:47:16Z

JorgeR81
Oct 29, 2024

When you drag a Controller, the cursor moves away from the window bar

When you refresh, the X is blinking (not the refresh icon)

Edit: bonus bug - Controller windows remain when you open a new blank canvas
Edit2: Toggle button sometimes is ignored when opening/switching workflows

Yes, I have all these issues.

It seems there is a delay, relative to the cursor position, when we drag the controllers.

2 replies

chrisgoringe Oct 30, 2024
Maintainer Author

When you drag a Controller, the cursor moves away from the window bar

I think this should be working better now

When you refresh, the X is blinking (not the refresh icon)

Fixed on 1.2

Edit: bonus bug - Controller windows remain when you open a new blank canvas

I believe this is now fixed

Edit2: Toggle button sometimes is ignored when opening/switching workflows

I believe this is now fixed (the toggle is per-workflow)

JorgeR81 Oct 30, 2024

This all seems to be fixed except the lagging while moving.
It seems a bit better but it's still there

But now it seems I also have the same lag when dragging nodes.
Even with all extensions be disabled.
And even in a previous portable install, without any updates or extensions.

Maybe I always had lag and did not notice it ?!

Maybe it was some Chrome update ?

chrisgoringe · 2024-10-30T01:18:16Z

chrisgoringe
Oct 30, 2024
Maintainer Author

If you have the Use Everywhere extension, update it. A recent Comfy update caused a significant performance issue for which I pushed a fix.

…

On Wed, 30 Oct 2024 at 12:03, JorgeR81 ***@***.***> wrote: This all seems to be fixed except the lagging while moving. It seems a bit better but it's still there ------------------------------ But now it seems I also have the same lag when dragging nodes. Even with all extensions be disabled. And even in a previous portable install, without any updates or extensions. Maybe I always had lag and did not notice it ?! Maybe it was some Chrome update ? — Reply to this email directly, view it on GitHub <#232 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBLMA2FCMZPK4SKWHUFGATZ6AV7LAVCNFSM6AAAAABQZG6GL2VHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMBZGQYDGNA> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

3 replies

JorgeR81 Oct 30, 2024

The Use Everywhere issue seems fixed.
All the wireless inputs are drawn now !

But I still have some lag while dragging nodes.
Even in a different portable install, without extensions.
And it happens in Chrome and Edge.
Maybe it was a Windows 10 update?

@LukeG89, Did ComfyUI always have some degree of lag for you ? Not sure if I should open an issue in ComfyUI ?

chrisgoringe Oct 30, 2024
Maintainer Author

I'll look at the performance a bit... I have had issues once or twice, but I have a pretty fast machine (and not very complex workflows)

btw - did you see the invite to a discord server - https://discord.gg/p3vDHn3n - I think that might be a better place for these more involved discussions.

JorgeR81 Oct 30, 2024

I don't think it's extension related.
Maybe this will improve with the upcoming ComfyUI desktop application.

And thanks for the invite, I'll think about it.
I'm not on any social platforms.
I'm not a very social person, I guess.

chrisgoringe · 2024-10-30T03:44:12Z

chrisgoringe
Oct 30, 2024
Maintainer Author

I don’t use discord as a social media platform :). Just a place for threaded conversations (not unlike GitHub but I find it easier to keep track)

…

On Wed, 30 Oct 2024 at 1:40 PM, JorgeR81 ***@***.***> wrote: I don't think it's extension related. Maybe this will improve with the upcoming ComfyUI desktop application. And thanks for the invite, I'll think about it. I'm not on any social platforms. I'm not a very social person, I guess. — Reply to this email directly, view it on GitHub <#232 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBLMA2K47UTRTORN6SKVFLZ6BBLRAVCNFSM6AAAAABQZG6GL2VHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMBZGQ2TKMA> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

0 replies

chrisgoringe · 2024-10-30T05:37:09Z

chrisgoringe
Oct 30, 2024
Maintainer Author

An update....

In order to get multiple views of the same widget all update on changes, I've needed to rework the code which keeps things in sync. The end result is actually a lot simpler, and hopefully much less likely to break, but I might have missed something. So on 1.2, keep an eye out for widgets not changing when the workflow one does and vica versa.