1.4 - not stable, do not raise issues!

[chrisgoringe]

Preliminary work on branch 1.4. Note that branch 1.4 is not stable, so if you find problems:

• wait five minutes, update, and try again. I might be actively working on it
• if it's still broken, report it HERE. Do not raise an issue.

[chrisgoringe]

Just pushed some code that should allow controllers to be resized by dragging any part of their border. The mouse pointer should indicate when you can clcik to drag.

[LukeG89]

There is only this problem

Resizing.mp4

[LukeG89]

Found another issue: Controller window is resizing if you grab nodeblocks right under the title

Resizing_2.mp4

[JorgeR81]

Controller window is resizing if you grab nodeblocks right under the title

Ah yes, ... and the same happens if we grab the space between sliders.

[chrisgoringe]

OK, I think those two issues are now fixed on 1.4

[JorgeR81]

Yeah, they seem to be fixed.

[LukeG89]

Bug: Show Controller in Focus Mode doesn't work, Controller disappears and doesn't appear again like in this issue:

• [Bug] Controller disappears in Focus Mode (New frontend feature) #239

[chrisgoringe]

I believe this is now fixed on 1.4

[LukeG89]

Yes it's fixed!

Now the only problem left is about resizing. When you expand windows all the way down in fullscreen+focus mode, windows stay the same size when you exit both modes, and you can't reach widgets/nodes at the bottom.

Fullscreen+Focus.mp4

[JorgeR81]

I think that would be fixed with snapping.

[chrisgoringe]

yes, I'm not going to do anything on resizing before snapping, since it will all change

[chrisgoringe]

1.4 update - I've just pushed some fairly significant memory management changes. Possible something might break, possible it will help with the slowly degrading performance.

Possible it'll do neither :)

[JorgeR81]

After using it for a while, I don't see any performance issues.

All mute/bypass buttons are fast !

[chrisgoringe]

Good. I found a bunch of stuff that wasn't getting disposed of - but there's always the danger now that I've been too aggressive!

Still, I'm closing #324.

[JorgeR81]

Minor bug:

Sometimes the node highlight is still visible, when we hide the controller.

EDIT: I think this also hapened in 1.3.1

[LukeG89]

Similar issue can happen if you create a new workflow when a node was highlighted

Highlight.mp4

[chrisgoringe]

the first of these should be fixed on 1.4

How do you create a new workflow while a node is highlighted? Is there a keyboard shortcut?

[chrisgoringe]

Highlight when you do a new workflow should be fixed on 1.4 now.

[LukeG89]

How do you create a new workflow while a node is highlighted? Is there a keyboard shortcut?

Yes, I use ctrl+e for blank and ctrl+d for default (the blank one is a custom keybind)

[LukeG89]

Highlight when you do a new workflow should be fixed on 1.4 now.

Yes, it's fixed! No problem even when you switch workflows with shortcuts!

[chrisgoringe]

1.4 should also now have fixed the bug where the controllers all piled up on top of each other sometimes.

[LukeG89]

Yes! Seems fixed!

[chrisgoringe]

OK, first cut at snapping code just pushed to 1.4

[JorgeR81]

It's not working for me, in 1.4

[JorgeR81]

Bug:

The canvas freezes when:

• controllers are on top of each other
• we switch tabs and then switch back ( even when controllers are not on top of each other )

We need to click the browser's refresh button, to "fix" it.

[JorgeR81]

One thing it's working though:

If I manually place one controller, exactly over the other's border, I can move both controllers together.
It even snaps the borders together, when they are really close.

The problem is that there is nothing preventing us from "overshooting" and placing one controller on top of the other.

[chrisgoringe]

Yeah, I got it mostly working but wasn’t happy with it, and broke it doing a rewrite - then went out for the evening! I’ll post an update when I think it’s working again! Till then stick with dev!

…

On Wed, 13 Nov 2024 at 9:16 PM, JorgeR81 ***@***.***> wrote: One thing it's working though: If I manually place it on controller, exactly over the other border, I can move both controllers together. It even snaps the borders together, when they are really close. The problem is that there is nothing preventing us from overhoof tan place one controller on top of the other. work.jpg (view on web) <https://github.com/user-attachments/assets/f5b9d8ac-3282-4fb8-a8fc-98e622c712b0> — Reply to this email directly, view it on GitHub <#323 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBLMAZV5R4N3LCUDOK6GAT2AMRGXAVCNFSM6AAAAABRQ3EC7OVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMRTHAZDEMI> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

[chrisgoringe]

OK, snapping updated. See how it feels.

[chrisgoringe]

Just to clarify:

THRESHOLD is how far from exactly aligned two controllers need to be for them to 'snap' together. They should then more-or-less perfectly align. It applies in both x and y directions, and also applies to the top and bottom (if snapped in x)

OVERLAP is how much the two controllers overlap by when snapped together. The default is the thickness of the border, so that their borders should exactly overlap.

[chrisgoringe]

On highlighting the snapped gutters... I'm thinking about how to do this. It isn't trivial :)

[JorgeR81]

THRESHOLD is how far from exactly aligned two controllers need to be for them to 'snap' together. They should then more-or-less perfectly align. It applies in both x and y directions, and also applies to the top and bottom (if snapped in x)

OK, so now THRESHOLD is working when the 2 gutters are already touching, to also align the controllers in the other direction.
But we also need it to work when the gutters are not touching.

On highlighting the snapped gutters... I'm thinking about how to do this. It isn't trivial :)

This would be nice, but not essential.
We can clearly see snapping is happening, because the windows are moving automatically ( according to the THRESHOLD ).

Even just among aesthetic improvements, I think these would be more important: #314 (comment)
Because these we can always see, ( not only for a second ).

[chrisgoringe]

Ah, just found a bug in the snap together. Should be working better now. Also upped THRESHOLD to 8 default.

[chrisgoringe]

push highlighting the overlapping gutters (off during drag for performance reasons).

I'm not sold on what it looks like, interested in aesthetic suggestions.

[chrisgoringe]

So, I think snapping is basically in place. If there are no blocking issues, I will merge it onto dev soonish (might be a few days, real life...)

I am aware of the following, and will raise tasks for them, but don't think they block a merge to dev:

• gutter aesthetics
• snap to bottom and right
• user setting for snapping (allowing THRESHOLD to be set, or feature turned off)
• need to not allow controllers to overlap if snapping is on; any overlap should result in a snap
• snapping etc when controller minimised
• possible performance issues

[chrisgoringe]

highlighting when they are going to snap is quite likely to lead to performance issues... at present the work only needs to be done on mouseup, but that would require it to be done continuously as the windows are moved...

I can remove the current effect, but adding the dynamic effect is unlikely to be on my priority list.

[JorgeR81]

Yeah, if it can lead to performance issues, it's better not having it.

[LukeG89]

Maybe an alternative would be for the gutter to be highlighted right after the snapping (as a visual confirmation), but when you click somewhere else the highlighting stops.

[JorgeR81]

but when you click somewhere else the highlighting stops.

If we have a highlight, it may look better if it's "on" for 1 or 2 seconds after snapping and then it stops on its own. 

---

But as mentioned before, it's already super clear that the gutters are snapping together.

This is just eye candy :)

I'm in favor of that !

But it would need to look similar to ComfyUI's eye candy.

I think in the ComfyUI Sidebar, there's even an ( inverse ) "fading" effect when the gutter is highlighted.
It seems it does not turn fully blue instantaneously, but gradually, when we mouseover.
This may be hard to replicate.

It's probably better not having any gutter highlight effects on the Controller, if they don't look like ComfyUI effects.
Having different effects would just make the Controller feel less "native", less integrated in ComfyUI.

[chrisgoringe]

raised #334 #335 #336 #337 in a new milestone (1.4.1)

[JorgeR81]

Aesthetic suggestions:

• Increase gap between node panels and gutter ( same as gutter thickness )
• Change gutter's color ( same as Sidebar's gutter )
• When snapping to the Sidebar or Top Bar, let the Controller's gutter be overlaid and hidden behind them.

This way we have the same aesthetics on the Sidebar and the snapped windows.
It all fits together, like native ComfyUI panels !

---

mockup

---

original

[chrisgoringe]

OK, I think that's done and pushed. I've also tweaked the spacing around the sliders etc to make the borders more consistent.

[LukeG89]

Now the header looks slightly better. The button is the same size as before?

Can you align the button to the center-left instead of the top-left? It is a bit off compared to the title.

For all other changes I leave all opinions to @JorgeR81! 😜

[chrisgoringe]

button is slightly larger (was 0.95em, now 1.05em), button and text are base-aligned.

[LukeG89]

button and text are base-aligned.

Ah, now I see that!

[chrisgoringe]

Yeah. But that close up makes the point - the icon should be lower. Central to the header, I think, which ought to align with the full height capitals. Pushed a small change.

[chrisgoringe]

1.4 has been merged onto dev. Closing this discussion. Issues can now be raised directly. Note a number already have been: https://github.com/chrisgoringe/cg-controller/milestone/32