feat!: use vim.ui.select, telescope thus no longer hard dependency

`telescope` is still required for `.interactiveStaging()`, since it
requires a preview, which `vim.ui.select` does not provide.

Author: chrisgrieser

README.md

@@ -6,29 +6,6 @@
 
 Bundle of commands focused on swift and streamlined git operations.
 
-<!-- DEPRECATION 2025-03-03 -->
-## Breaking changes in v1.0
-- `dressing.nvim` and `nvim-notify` are **no longer dependencies**.
-- `telescope.nvim` is now a **required dependency**.
-- The `commit.insertIssuesOnHashSign` feature has been removed. Better issue
-  insertion via plugins like [cmp-git](https://github.com/petertriho/cmp-git) or
-  [blink-cmp-git](https://github.com/Kaiser-Yang/blink-cmp-git) now work there.
-- `smartCommit` was overhauled. Among other improvements, it now supports a
-  commit body.
-
-> [!NOTE]
-> If you want to keep using the previous version, without these breaking
-> changes, you can pin the tag `v0.9`:
->
-> ```lua
-> -- lazy.nvim
-> {
-> 	"chrisgrieser/nvim-tinygit",
-> 	tag = "v0.9"
-> 	dependencies = "stevearc/dressing.nvim",
-> },
-> ```
-
 ## Feature overview
 
 <table>
@@ -95,9 +72,18 @@ Bundle of commands focused on swift and streamlined git operations.
 ## Installation
 **Requirements**
 - nvim 0.10+
-- [telescope.nvim](https://github.com/nvim-telescope/telescope.nvim)
-- `curl` for GitHub-related features
-- *optional*: Treesitter parser for syntax highlighting: `TSInstall gitcommit`
+- for interactive staging:
+  [telescope.nvim](https://github.com/nvim-telescope/telescope.nvim) for (PRs
+  adding support for other pickers welcome)
+- for GitHub-related commands: `curl`
+- *recommended*: Treesitter parser for syntax highlighting: `TSInstall
+  gitcommit`
+- *recommended*: a plugin implementing `vim.ui.select`, such as:
+  * [snacks.picker](http://github.com/folke/snacks.nvim)
+  * [mini.pick](http://github.com/echasnovski/mini.pick)
+  * [telescope.nvim](https://github.com/nvim-telescope/telescope.nvim) with
+	[telescope-ui-select](https://github.com/nvim-telescope/telescope-ui-select.nvim)
+  * [fzf-lua](https://github.com/ibhagwan/fzf-lua)
 
 ```lua
 -- lazy.nvim
@@ -228,8 +214,10 @@ since the `:Tinygit` does not accept command-specific options and does not
 trigger visual-mode specific changes to the commands.
 
 ### Interactive staging
-- This command stages hunks, that is, *parts* of a file instead of the
-  full file. It is roughly comparable to `git add -p`.
+- Interactive straging requires `telescope`. (PRs adding support for other
+  pickers welcome.)
+- This command stages hunks, that is, *parts* of a file instead of the full
+  file. It is roughly comparable to `git add -p`.
 - Use `<Space>` to (un)stage the hunk, `<CR>` to go to the hunk, or `<C-r` to
   reset the hunk (mappings customizable). Your regular `telescope` mappings also
   apply.
@@ -322,7 +310,7 @@ require("tinygit").undoLastCommitOrAmend()
 
 ### GitHub interaction
 **Search issues & PRs**  
-- Requires `curl`.
+- The GitHub interaction commands all require `curl`.
 
 ```lua
 -- state: all|closed|open (default: all)

lua/tinygit/commands/commit.lua

@@ -252,7 +252,7 @@ function M.fixupCommit(opts)
 		updateStatusline()
 	end
 
-	require("tinygit.shared.picker").withTelescope(
+	require("tinygit.shared.picker").pick(
 		prompt,
 		commits,
 		commitFormatter,

lua/tinygit/commands/github.lua

@@ -157,7 +157,7 @@ function M.issuesAndPrs(opts)
 		return ("%s #%s %s by %s"):format(icon, issue.number, issue.title, issue.user.login)
 	end
 
-	require("tinygit.shared.picker").withTelescope(
+	require("tinygit.shared.picker").pick(
 		prompt,
 		issues,
 		issueListFormatter,

lua/tinygit/commands/history.lua

@@ -314,7 +314,7 @@ local function selectFromCommits(commitList)
 	end
 	local onChoice = function(_, commitIdx) showDiff(commitIdx) end
 
-	require("tinygit.shared.picker").withTelescope(
+	require("tinygit.shared.picker").pick(
 		prompt,
 		commits,
 		commitFormatter,

lua/tinygit/shared/picker.lua

@@ -1,68 +1,30 @@
 local M = {}
-
-local u = require("tinygit.shared.utils")
 --------------------------------------------------------------------------------
 
 ---@param prompt string
 ---@param items any[]
 ---@param itemFormatter fun(item: any): string
 ---@param stylingFunc fun()
 ---@param onChoice fun(item: any, index?: number)
-function M.withTelescope(prompt, items, itemFormatter, stylingFunc, onChoice)
-	local installed, _ = pcall(require, "telescope")
-	if not installed then
-		u.notify("telescope.nvim is not installed.", "warn")
-		return
-	end
-
-	local finders = require("telescope.finders")
-	local pickers = require("telescope.pickers")
-	local telescopeConf = require("telescope.config").values
-	local actionState = require("telescope.actions.state")
-	local actions = require("telescope.actions")
-
-	-- INFO implement styling via `autocmd` instead of telescope's `entry_maker`,
-	-- since the former is more generic, and can be used for potential other
-	-- pickers in the future
-	vim.api.nvim_create_autocmd("FileType", {
+function M.pick(prompt, items, itemFormatter, stylingFunc, onChoice)
+	-- Add some basic styling & backdrop, if using `telescope` or `snacks.picker`
+	local autocmd = vim.api.nvim_create_autocmd("FileType", {
 		desc = "Tinygit: Styling for TelescopeResults",
 		once = true,
-		pattern = "TelescopeResults",
-		callback = stylingFunc,
+		pattern = { "TelescopeResults", "snacks_picker_list" },
+		callback = function(ctx)
+			vim.schedule(function() vim.api.nvim_buf_call(ctx.buf, stylingFunc) end)
+			require("tinygit.shared.backdrop").new(ctx.buf)
+		end,
 	})
 
-	local telescopeOpts = {
-		layout_strategy = "horizontal",
-		layout_config = {
-			horizontal = {
-				width = { 0.9, max = 100 },
-				height = { 0.6, max = 40 },
-			},
-		},
-	}
-
-	-- DOCS https://github.com/nvim-telescope/telescope.nvim/blob/master/developers.md#first-picker
-	pickers
-		.new(telescopeOpts, {
-			prompt_title = prompt,
-			sorter = telescopeConf.generic_sorter {},
-			finder = finders.new_table {
-				results = items,
-				entry_maker = function(item)
-					local display = itemFormatter(item)
-					return { value = item, display = display, ordinal = display }
-				end,
-			},
-			attach_mappings = function(promptBufnr, _)
-				actions.select_default:replace(function()
-					actions.close(promptBufnr)
-					local selection = actionState.get_selected_entry()
-					onChoice(selection.value, selection.index)
-				end)
-				return true -- `true` = keep other mappings from the user
-			end,
-		})
-		:find()
+	vim.ui.select(items, {
+		prompt = prompt,
+		format_item = itemFormatter,
+	}, function(selection, index)
+		if selection then onChoice(selection, index) end
+		vim.api.nvim_del_autocmd(autocmd)
+	end)
 end
 
 --------------------------------------------------------------------------------