Merge pull request Alexia#17 from macbre/deprecated-new-operator-with-reference

Add a check for new operator with reference

Author: Alexia

classes/tests/critical.php

@@ -27,7 +27,8 @@ class critical {
 		'variableInterpolation',
 		'duplicateFunctionParameter',
 		'reservedNames',
-		'deprecatedFunctions'
+		'deprecatedFunctions',
+		'newOperatorWithReference',
 	];
 
 	/**
@@ -116,5 +117,21 @@ public function _deprecatedFunctions($line) {
 		}
 		return false;
 	}
+
+	/**
+	 * New objects cannot be assigned by reference
+	 *
+	 * @access	public
+	 * @param	string	Line to test against.
+	 * @return	boolean	Line matches test.
+	 */
+	public function _newOperatorWithReference($line) {
+		$regex = "#&\s?new\s#";
+
+		if (preg_match($regex, $line)) {
+			return true;
+		}
+		return false;
+	}
 }
-?>
+?>

testcases.php

@@ -122,4 +122,8 @@ trait numeric { /*...*/ }
 mysql_tablename();
 mysql_thread_id();
 mysql_unbuffered_query();
-?>
+
+// New objects cannot be assigned by reference
+class C {}
+$c =& new C;
+$c =&new C;