Merge pull request #174 from chriskuehl/skip-installing-setuptools

preinstall setuptools for `pip download`

Author: asottile

tests/conftest.py

@@ -11,7 +11,7 @@
 import requests
 
 
-PIP_TEST_VERSION = '23.2.1'
+PIP_TEST_VERSION = '25.1.1'
 
 
 UrlAndPath = collections.namedtuple('UrlAndPath', ('url', 'path'))
@@ -62,6 +62,7 @@ def install_pip(version, path):
 
     pip = path.join('bin', 'pip').strpath
     subprocess.check_call((pip, 'install', '-i', 'https://pypi.org/simple', f'pip=={version}'))
+    subprocess.check_call((pip, 'install', '-i', 'https://pypi.org/simple', 'setuptools'))
 
     version_output = subprocess.check_output((pip, '--version'))
     assert version_output.split()[1].decode('ascii') == version

tests/integration_test.py

@@ -28,7 +28,7 @@ def install_packages(path, fake_packages):
 
 def pip_download(pip, index_url, path, *spec):
     subprocess.check_call(
-        (pip, 'download', '-i', index_url, '--dest', path, *spec),
+        (pip, 'download', '-i', index_url, '--dest', path, *spec, '--no-use-pep517'),
     )
 
 
@@ -152,6 +152,6 @@ def test_pip_uses_core_metadata(capfd, tmpdir, tmpweb, pip):
     downloaded_package, = tmpdir.listdir(fil=os.path.isfile)
     assert downloaded_package.basename == 'foo-1-py2.py3-none-any.whl'
     assert (
-        f'Obtaining dependency information for foo from {tmpweb.url}/pool/foo-1-py2.py3-none-any.whl.metadata'
+        f'Downloading {tmpweb.url}/pool/foo-1-py2.py3-none-any.whl.metadata'
         in capfd.readouterr().out
     )