Skip to content

Commit 902b31c

Browse files
Merge pull request puppetlabs#1165 from david22swan/puppetlabsGH-1164/main/jump_fix
(puppetlabsGH-1164) Only common jump values should be enforced as upcase
2 parents 7fe73ee + 43d5e73 commit 902b31c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

lib/puppet/provider/firewall/firewall.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -863,8 +863,10 @@ def self.process_input(should)
863863
should[key][0] = ['!', should[key][0]].join(' ') if negated
864864
end
865865

866-
# `jump` values should always be uppercase
867-
should[:jump] = should[:jump].upcase if should[:jump]
866+
# `jump` common values should always be uppercase
867+
jump_common_values = ['accept', 'reject', 'drop', 'queue', 'return', 'dnat', 'snat', 'log', 'nflog',
868+
'netmp', 'masquerade', 'redirect', 'mark', 'ct']
869+
should[:jump] = should[:jump].upcase if should[:jump] && jump_common_values.include?(should[:jump].downcase)
868870

869871
# `source` and `destination` must be put through host_to_mask
870872
should[:source] = PuppetX::Firewall::Utility.host_to_mask(should[:source], should[:protocol]) if should[:source]

0 commit comments

Comments
 (0)