ES|QL: Improve value loading for match_only_text mapping (elastic#137026)

Author: ioanatia

docs/changelog/137026.yaml

@@ -0,0 +1,5 @@
+pr: 137026
+summary: Improve value loading for `match_only_text` mapping
+area: ES|QL
+type: enhancement
+issues: []

modules/mapper-extras/src/main/java/org/elasticsearch/index/mapper/extras/MatchOnlyTextFieldMapper.java

@@ -602,6 +602,28 @@ protected String delegatingTo() {
                 }
             }
 
+            /*
+             * TODO: This duplicates code from TextFieldMapper
+             * If this is a sub-text field try and return the parent's loader. Text
+             * fields will always be slow to load and if the parent is exact then we
+             * should use that instead.
+             */
+            String parentField = blContext.parentField(name());
+            if (parentField != null) {
+                MappedFieldType parent = blContext.lookup().fieldType(parentField);
+                if (parent.typeName().equals(KeywordFieldMapper.CONTENT_TYPE)) {
+                    KeywordFieldMapper.KeywordFieldType kwd = (KeywordFieldMapper.KeywordFieldType) parent;
+                    if (kwd.hasNormalizer() == false && (kwd.hasDocValues() || kwd.isStored())) {
+                        return new BlockLoader.Delegating(kwd.blockLoader(blContext)) {
+                            @Override
+                            protected String delegatingTo() {
+                                return kwd.name();
+                            }
+                        };
+                    }
+                }
+            }
+
             // fallback to _source (synthetic or not)
             SourceValueFetcher fetcher = SourceValueFetcher.toString(blContext.sourcePaths(name()), blContext.indexSettings());
             // MatchOnlyText never has norms, so we have to use the field names field

modules/mapper-extras/src/test/java/org/elasticsearch/index/mapper/extras/MatchOnlyTextFieldTypeTests.java

@@ -49,6 +49,7 @@
 import org.elasticsearch.index.mapper.TextSearchInfo;
 import org.elasticsearch.index.mapper.extras.MatchOnlyTextFieldMapper.MatchOnlyTextFieldType;
 import org.elasticsearch.script.ScriptCompiler;
+import org.elasticsearch.search.lookup.SearchLookup;
 import org.hamcrest.Matchers;
 
 import java.io.IOException;
@@ -372,4 +373,36 @@ public void testBlockLoaderDoesNotUseSyntheticSourceDelegateWhenIgnoreAboveIsSet
         // verify that we don't delegate anything
         assertThat(blockLoader, Matchers.not(Matchers.instanceOf(BlockLoader.Delegating.class)));
     }
+
+    public void testBlockLoaderDelegateToKeywordFieldWhenSyntheticSourceIsDisabled() {
+        String parentFieldName = "foo";
+        String childFieldName = "foo.bar";
+        // given
+        KeywordFieldMapper.KeywordFieldType keywordFieldType = new KeywordFieldMapper.KeywordFieldType(
+            parentFieldName,
+            true,
+            true,
+            Collections.emptyMap()
+        );
+
+        MatchOnlyTextFieldMapper.MatchOnlyTextFieldType ft = new MatchOnlyTextFieldMapper.MatchOnlyTextFieldType(
+            childFieldName,
+            new TextSearchInfo(TextFieldMapper.Defaults.FIELD_TYPE, null, Lucene.STANDARD_ANALYZER, Lucene.STANDARD_ANALYZER),
+            mock(NamedAnalyzer.class),
+            false,
+            Collections.emptyMap(),
+            true,
+            false,
+            keywordFieldType
+        );
+
+        var mockedSearchLookup = mock(SearchLookup.class);
+        when(mockedSearchLookup.fieldType(parentFieldName)).thenReturn(keywordFieldType);
+
+        var mockedBlockLoaderContext = mock(MappedFieldType.BlockLoaderContext.class);
+        when(mockedBlockLoaderContext.parentField(childFieldName)).thenReturn(parentFieldName);
+        when(mockedBlockLoaderContext.lookup()).thenReturn(mockedSearchLookup);
+        BlockLoader blockLoader = ft.blockLoader(mockedBlockLoaderContext);
+        assertThat(blockLoader, Matchers.instanceOf(BlockLoader.Delegating.class));
+    }
 }