Multiple variable definition

[CTBT]

Describe the bug
When i generate the .http file with the output-type set to "OneFile" the generated file contains several requests that define a variable with the same name. This leads to multiple variable definition statements of the same variable which leads to an error.

`

foo

@id = 0

GET http://test.com/foo{{id}}

bar

@id = 0

GET http://test.com/bar{{id}}
`

Cannot execute request, because it references ambiguous variable 'id'

Support Key: [my-support-key]

[christianhelle]

@CTBT Thanks for taking the time to report this

This bug is something I introduced very recently! Having a large .http file isn't my usual workflow and I just built it as someone else suggested it. I never got to testing it properly.

This should be easy to fix. Let me see what I can do

[christianhelle]

@CTBT Sorry for the delay, it took some effort but I finally found time to work on this...

I have a solution that will prefix the route variables with a unique operation name so generating a single file output will look something like this:

@contentType = application/json


#######################################
### Request: GET /pet/{petId}
### Summary: Find pet by ID
### Description: Returns a single pet
#######################################

### Path Parameter: ID of pet to return
@GetPetById_petId = 0


GET https://petstore3.swagger.io//api/v3/pet/{{GetPetById_petId}}
Content-Type: {{contentType}}


##################################
### Request: DELETE /pet/{petId}
### Summary: Deletes a pet
##################################

### Path Parameter: Pet id to delete
@DeletePet_petId = 0


DELETE https://petstore3.swagger.io//api/v3/pet/{{DeletePet_petId}}
Content-Type: {{contentType}}

Will this work for you?

[rmunk]

@christianhelle I have found an issue with this approach. When you have endpoints with multiple route parameters the generated variable names contain curly braces which breaks the generated code. Quick solution that comes to mind would be to replace the curly braces with underscore when generating variable names.

[christianhelle]

@rmunk thanks for bringing this up. Do you mind sharing an OpenAPI spec example where this problem occurs? It would make it easier for me to test and fix