User lists - allow patch sort and info display change

[RadekPilich]

Currently, patch sorting and auxiliary info display change doesn't work for user lists.

Can it be incorporated there as well?

Both would be useful not only for display of the current list, but more importantly for creation of a new organized list based on the current list.

As a side note, the meaning of the second sentence in this dialogue is unclear to me.

And a second side note - when the "duplicate names" filter is used on the user list, it detects internally different patches with the same name, but it doesn't detect the same patch being included multiple times in the list. I think the second case would be useful to have here as well, although it might be confusing if mixed together with the first case.

[christofmuc]

Oh, sorting of lists - I don't think this is implemented, lists currently are displayed in order of lists, and you can rearrange via drag and drop in the tree view. We could allow sorting, but it might be a little brittle when the intent is to create reordered lists on the new one, because the sorting itself is not part of the list, and the drag and drop operation is completely independent of the view that uses the sorting. Maybe a "reorder" function is easier to understand (edit... lists... sort by name/number/?).

The second sentence I don't understand either, I have to investigate the code to see what I might have wanted to convey.

The duplicate names filter is explicitly for multiple patches with different hash having the same name. In a list, a patch duplicate could be of the same hash, and is most likely intentional. The search criterion for "list duplicate" is easier than duplicate name, and is specific for lists as in the Library view each patch can only appear once anyway. I think it's separate feature to filter by duplicate list entries. I'll make an enhancement ticket.

[RadekPilich]

I understand the drag and drop reordering of lists and its reuse for reordering of patches in user lists. I mean I do now, I haven't used user list before today.

I am not proposing the reordering of the list stored in the DB, I just want to reorder the result set of a DB select like we can do with any other result set. Then if desired, we can store the ordered result set as a new user list and do final fine tuning via drag and drop. I believed this would be minimal effort change.

Other possibility I thought of would be to have sort type selector on the create user list / bank dialogue. That seems less flexible though and lacks a preview of the order before committing it to the DB as a new list.

[RadekPilich]

A duplicate patch in a list is likely intentional in the final version of a list. The process of creating the final version can be a bit clumsy. What I did today is to do several searches, each of them producing between 5-20 patches I wanted to include in my list. So I was saving these result sets as individual user lists and then drag and drop merging them together. That naturally resulted in some patch duplicities, as they turned out to be in result sets of two or more queries.