Skip to content

Commit 67ce85d

Browse files
test: fix type error and extend coverage
1 parent 8be7607 commit 67ce85d

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

src/log-record.test.ts

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,14 @@ describe("LogRecord", () => {
3030
expect(record.date).toStrictEqual(date);
3131
});
3232

33+
// Some helpers for the following test cases
34+
function sum(a: number, b: number) {
35+
return a + b;
36+
}
37+
const stackErr = new Error("Stack error");
38+
const testErr = Error("Test error");
39+
testErr.stack = undefined;
40+
3341
const cases: [args: unknown[], parsed: string][] = [
3442
[[], ""],
3543
[["log message"], "log message"],
@@ -42,21 +50,16 @@ describe("LogRecord", () => {
4250
[[{ key: 1, key2: 2 }], '{"key":1,"key2":2}'],
4351
[[null], "null"],
4452
[[undefined, 1], "undefined 1"],
45-
[
46-
[
47-
function sum(a: number, b: number) {
48-
return a + b;
49-
},
50-
],
51-
"[Function sum]",
52-
],
53+
[[sum], "[Function sum]"],
5354
[
5455
[
5556
[1, 2, 3],
5657
[4, 5, 6],
5758
],
5859
"[1,2,3] [4,5,6]",
5960
],
61+
[[stackErr], stackErr.stack as string],
62+
[[testErr], "Test error"],
6063
];
6164

6265
it.each(cases)('Given arguments "%s" are parsed to "%s"', (args, parsed) => {

src/log-record.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ function asString(data: unknown): string {
7070
typeof data === "number" ||
7171
typeof data === "bigint" ||
7272
typeof data === "boolean" ||
73-
typeof data === "undefined" ||
7473
typeof data === "symbol"
7574
) {
7675
return String(data);

src/test-helper/log-record-builder.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ export function buildLogRecord(overrides?: Partial<ILogRecord>): ILogRecord {
77
date: new Date(),
88
level: LogLevel.DEBUG,
99
levelName: getLogLevelName(overrides?.level ?? LogLevel.DEBUG),
10-
message: "Test message",
10+
args: ["message", 123],
11+
message: "message 123",
1112
metadata: { test: "Test meta" },
1213
...overrides,
1314
};

0 commit comments

Comments
 (0)