Skip to content

Commit 6c874f2

Browse files
vzaidmanmeta-codesync[bot]
authored andcommitted
Fix SoLoader race condition in InspectorNetworkRequestListener (facebook#54029)
Summary: Pull Request resolved: facebook#54029 Changelog: [Android][Fixed] Fixed `SoLoader` race condition in `InspectorNetworkRequestListener` When enabling `LoadNetworkResrouce` with flag `nativeSourceCodeFetching` in `InspectorInterfaces.h`, running the app, and opening the debugger, the app was crashing with ``` No implementation found for void com.facebook.react.devsupport.inspector.InspectorNetworkRequestListener.onHeaders(int, java.util.Map) ( tried Java_com_facebook_react_devsupport_inspector_InspectorNetworkRequestListener_onHeaders and Java_com_facebook_react_devsupport_inspector_InspectorNetworkRequestListener_onHeaders__ILjava_util_Map_2 ) - is the library loaded, e.g. System.loadLibrary? ``` Reviewed By: huntie Differential Revision: D83741114 fbshipit-source-id: b878fb4680e6a51f9403e8dea2872da85254e024
1 parent 53dc68a commit 6c874f2

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/inspector/InspectorNetworkRequestListener.kt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ package com.facebook.react.devsupport.inspector
1010
import com.facebook.jni.HybridData
1111
import com.facebook.proguard.annotations.DoNotStrip
1212
import com.facebook.proguard.annotations.DoNotStripAny
13+
import com.facebook.soloader.SoLoader
1314

1415
/**
1516
* JNI wrapper for `jsinspectormodern::NetworkRequestListener`. Handles the `ScopedExecutor`
@@ -26,4 +27,10 @@ internal class InspectorNetworkRequestListener(
2627
external fun onError(message: String?)
2728

2829
external fun onCompletion()
30+
31+
companion object {
32+
init {
33+
SoLoader.loadLibrary("reactnativejni")
34+
}
35+
}
2936
}

0 commit comments

Comments
 (0)