Skip to content

Commit 880b7e2

Browse files
generatedunixname89002005287564meta-codesync[bot]
authored andcommitted
Fix CQS signal readability-named-parameter in xplat/js/react-native-github/packages [B] (facebook#54025)
Summary: Pull Request resolved: facebook#54025 Reviewed By: rshest Differential Revision: D83704348 fbshipit-source-id: 8f5e34aa1b344a30dfea26661ac7b71fa4b2ddb1
1 parent bcf9748 commit 880b7e2

File tree

8 files changed

+13
-11
lines changed

8 files changed

+13
-11
lines changed

packages/react-native/ReactCommon/react/bridging/Bool.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace facebook::react {
1313

1414
template <>
1515
struct Bridging<bool> {
16-
static bool fromJs(jsi::Runtime&, const jsi::Value& value) {
16+
static bool fromJs(jsi::Runtime& /*unused*/, const jsi::Value& value) {
1717
return value.asBool();
1818
}
1919

packages/react-native/ReactCommon/react/bridging/Class.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,12 @@ JSReturnT callFromJs(
8686
}
8787

8888
template <typename ReturnT, typename... ArgsT>
89-
constexpr size_t getParameterCount(ReturnT (*)(ArgsT...)) {
89+
constexpr size_t getParameterCount(ReturnT (* /*unused*/)(ArgsT...)) {
9090
return sizeof...(ArgsT);
9191
}
9292

9393
template <typename Class, typename ReturnT, typename... ArgsT>
94-
constexpr size_t getParameterCount(ReturnT (Class::*)(ArgsT...)) {
94+
constexpr size_t getParameterCount(ReturnT (Class::* /*unused*/)(ArgsT...)) {
9595
return sizeof...(ArgsT);
9696
}
9797

packages/react-native/ReactCommon/react/bridging/Function.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,8 @@ class SyncCallback<R(Args...)> {
179179
}
180180

181181
template <size_t... Index>
182-
R apply(std::tuple<Args...>&& args, std::index_sequence<Index...>) const {
182+
R apply(std::tuple<Args...>&& args, std::index_sequence<Index...> /*unused*/)
183+
const {
183184
return call(std::move(std::get<Index>(args))...);
184185
}
185186

@@ -262,7 +263,7 @@ struct Bridging<std::function<R(Args...)>> {
262263
jsi::Runtime& rt,
263264
const jsi::Value* args,
264265
const std::shared_ptr<CallInvoker>& jsInvoker,
265-
std::index_sequence<Index...>) {
266+
std::index_sequence<Index...> /*unused*/) {
266267
return fn(bridging::fromJs<Args>(rt, args[Index], jsInvoker)...);
267268
}
268269
};

packages/react-native/ReactCommon/react/bridging/Value.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ struct Bridging<std::nullptr_t> {
2424
}
2525
}
2626

27-
static std::nullptr_t toJs(jsi::Runtime&, std::nullptr_t) {
27+
static std::nullptr_t toJs(jsi::Runtime& /*unused*/, std::nullptr_t) {
2828
return nullptr;
2929
}
3030
};

packages/react-native/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ class JSI_EXPORT JavaTurboModule : public TurboModule {
5353
protected:
5454
void configureEventEmitterCallback();
5555

56-
[[deprecated]] void setEventEmitterCallback(jni::alias_ref<jobject>) {
56+
[[deprecated]] void setEventEmitterCallback(
57+
jni::alias_ref<jobject> /*unused*/) {
5758
configureEventEmitterCallback();
5859
}
5960

packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ class ParagraphAttributes : public DebugStringConvertible {
8282
*/
8383
std::optional<TextAlignmentVertical> textAlignVertical{};
8484

85-
bool operator==(const ParagraphAttributes&) const;
86-
bool operator!=(const ParagraphAttributes&) const;
85+
bool operator==(const ParagraphAttributes& rhs) const;
86+
bool operator!=(const ParagraphAttributes& rhs) const;
8787

8888
#pragma mark - DebugStringConvertible
8989

packages/react-native/ReactCommon/react/renderer/components/view/accessibilityPropsConversions.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ inline void fromRawValue(
233233
}
234234

235235
inline void fromRawValue(
236-
const PropsParserContext&,
236+
const PropsParserContext& /*unused*/,
237237
const RawValue& value,
238238
AccessibilityValue& result) {
239239
auto map = (std::unordered_map<std::string, RawValue>)value;

packages/react-native/ReactCommon/react/renderer/css/CSSValueParser.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class CSSValueParser {
3434
template <CSSDataType... AllowedTypesT>
3535
constexpr std::variant<std::monostate, AllowedTypesT...> consumeValue(
3636
CSSDelimiter delimeter,
37-
CSSCompoundDataType<AllowedTypesT...>) {
37+
CSSCompoundDataType<AllowedTypesT...> /*unused*/) {
3838
using ReturnT = std::variant<std::monostate, AllowedTypesT...>;
3939

4040
auto consumedValue =

0 commit comments

Comments
 (0)