Skip to content

Commit 420990b

Browse files
committed
fixes
1 parent 46b626c commit 420990b

File tree

10 files changed

+47
-18
lines changed

10 files changed

+47
-18
lines changed

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,7 @@ in the meantime check out what's in the examples directory (especially the simpl
2929
* currently the "find song in queue" can't retrieve songs by queue index, is this useful anyway?
3030
* let the user modify the audio graph, for example by adding / removíng nodes like a filter node, a panner node ...
3131
* implement suspend and resume: ctx.suspend() and resume of the context on pause / stop or if for some time no sound was played? ... to free device resources, as suspend returns a promise, does this mean suspending and resuming takes time? if so how much time does it take, based on that information we can decide when and how often we should resume / suspend
32+
33+
## DONE
34+
3235
* let the user add a sound with an already fetched ArrayBuffer or even with an already decoded AudioBuffer?

build/@types/web-audio-api-player/library/request.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ export interface IRequested {
44
url: string;
55
loadingProgress: number;
66
onLoading?: IOnProgress;
7-
onPlaying?: IOnProgress;
87
}
98
export declare class PlayerRequest {
109
getArrayBuffer(requested: IRequested): Promise<ArrayBuffer | IPlayerError>;

build/@types/web-audio-api-player/library/sound.d.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@ export interface ISoundAttributes {
1313
loop?: boolean;
1414
onLoading?: IOnProgress;
1515
onPlaying?: IOnProgress;
16+
audioBuffer?: AudioBuffer | null;
17+
arrayBuffer?: ArrayBuffer | null;
1618
}
17-
export interface ISound extends IRequested, ISoundAttributes {
19+
export interface ISound extends ISoundAttributes, IRequested {
1820
sourceNode: AudioBufferSourceNode | null;
1921
isBuffered: boolean;
2022
isBuffering: boolean;

build/library/core.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/library/request.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)