Skip to content

Commit 83cc269

Browse files
committed
update deps, update eslint, fix typescript usage
1 parent a7e05fd commit 83cc269

File tree

18 files changed

+582
-828
lines changed

18 files changed

+582
-828
lines changed

.eslintignore

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,8 @@ dist
66
build
77

88
# don't lint rollup dist scripts
9-
scripts
9+
scripts
10+
11+
# package json and lock
12+
package.json
13+
package-lock.json

.eslintrc.json

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"root": true,
23
"env": {
34
"browser": true,
45
"node": false,
@@ -14,10 +15,17 @@
1415
],
1516
"parser": "@typescript-eslint/parser",
1617
"rules": {
17-
"@typescript-eslint/interface-name-prefix": [
18+
"@typescript-eslint/naming-convention": [
1819
"warn",
1920
{
20-
"prefixWithI": "always"
21+
"selector": "interface",
22+
"format": [
23+
"PascalCase"
24+
],
25+
"custom": {
26+
"regex": "^I[A-Z]",
27+
"match": true
28+
}
2129
}
2230
]
2331
}

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
# web audio API player
77

8+
<p align="center"><img width="400" src="./assets/web_audio_api_player_logo_small.png" alt="web audio API player logo"></p>
9+
810
## About this project
911

1012
🎶 An opensource javascript (typescript) audio player for the browser, built using the Web Audio API
27.5 KB
Loading

dist/index.js

Lines changed: 20 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.umd.js

Lines changed: 21 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/library/audio.d.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ interface IAudioGraph {
1515
oscillatorNode?: OscillatorNode;
1616
waveShaperNode?: WaveShaperNode;
1717
}
18+
interface IOnEnded {
19+
(event?: Event): void;
20+
}
1821
interface IAudioOptions {
1922
customAudioContext?: AudioContext;
2023
customAudioGraph?: IAudioGraph;
@@ -23,14 +26,14 @@ interface IAudioOptions {
2326
loadSoundMode: typeSoundModes;
2427
}
2528
interface IAudioBufferSourceOptions extends AudioBufferSourceOptions {
26-
onEnded: Function;
29+
onEnded: IOnEnded;
2730
}
2831
interface IMediaElementAudioSourceOptions extends MediaElementAudioSourceOptions {
29-
onEnded: Function;
32+
onEnded: IOnEnded;
3033
loop: boolean;
3134
}
3235
interface IMediaElementAudioSourceNode extends MediaElementAudioSourceNode {
33-
onended: Function;
36+
onended: IOnEnded;
3437
loop: boolean;
3538
}
3639
export interface IChangeVolumeOptions {

dist/library/core.d.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ interface ISoundsQueueOptions {
2626
}
2727
interface IDecodeSoundOptions {
2828
sound: ISound;
29-
resolve: Function;
30-
reject: Function;
3129
}
3230
interface IPlayOptions {
3331
whichSound?: number | string | undefined;
@@ -99,7 +97,7 @@ export declare class PlayerCore {
9997
protected _loadSoundUsingAudioElement(sound: ISound): Promise<ISound | PlayerError>;
10098
protected _loadSoundUsingRequest(sound: ISound): Promise<ISound | PlayerError>;
10199
protected _initializeAudioElementListeners(sound: ISound): void;
102-
protected _decodeSound({ sound, resolve, reject }: IDecodeSoundOptions): void;
100+
protected _decodeSound({ sound }: IDecodeSoundOptions): Promise<ISound>;
103101
play({ whichSound, playTimeOffset }?: IPlayOptions): Promise<void>;
104102
protected _play(sound: ISound): Promise<void>;
105103
protected _playAudioBuffer(sound: ISound): Promise<void>;

0 commit comments

Comments
 (0)