[ENH]: Modified AttachFunction to do 2PC on a new is_ready column

Author: tanujnay112

chromadb/test/distributed/test_task_api.py

@@ -5,8 +5,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/chroma-core/chroma/go/pkg/common"
-
 	"github.com/chroma-core/chroma/go/pkg/memberlist_manager"
 	"github.com/chroma-core/chroma/go/pkg/proto/coordinatorpb"
 	"github.com/chroma-core/chroma/go/pkg/sysdb/metastore/db/dbmodel"
@@ -225,10 +223,10 @@ func (suite *AttachFunctionTestSuite) TestAttachFunction_SuccessfulCreation() {
 	// Execute AttachFunction
 	response, err := suite.coordinator.AttachFunction(ctx, request)
 
-	// Assertions - heap service is not enabled in this test setup
-	suite.Error(err)
-	suite.Nil(response)
-	suite.ErrorIs(err, common.ErrHeapServiceNotEnabled)
+	// Assertions - AttachFunction now succeeds without heap service, creating attached function with is_ready=false
+	suite.NoError(err)
+	suite.NotNil(response)
+	suite.NotEmpty(response.Id)
 
 	// Verify all mocks were called as expected
 	suite.mockMetaDomain.AssertExpectations(suite.T())
@@ -407,11 +405,11 @@ func (suite *AttachFunctionTestSuite) TestAttachFunction_RecoveryFlow() {
 			_ = txFunc(context.Background())
 		}).Return(nil).Once()
 
-	// First AttachFunction call - should fail at heap push
+	// First AttachFunction call - should succeed, creating attached function with is_ready=false
 	response1, err1 := suite.coordinator.AttachFunction(ctx, request)
-	suite.Error(err1)
-	suite.Nil(response1)
-	suite.Contains(err1.Error(), "heap service")
+	suite.NoError(err1)
+	suite.NotNil(response1)
+	suite.NotEmpty(response1.Id)
 
 	// ========== GetAttachedFunctionByName: Should Return ErrAttachedFunctionNotReady ==========