Skip to content

Commit 1064fac

Browse files
authored
[CHORE] Bump max concurrent streams for log service (#5803)
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - Increase max concurrent streams for log service - New functionality - N/A ## Test plan _How are these changes tested?_ - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Migration plan _Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?_ ## Observability plan _What is the plan to instrument and monitor this change?_ ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
1 parent 0f7f7af commit 1064fac

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

rust/log-service/src/lib.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2021,6 +2021,7 @@ impl LogServerWrapper {
20212021

20222022
let max_encoding_message_size = log_server.config.max_encoding_message_size;
20232023
let max_decoding_message_size = log_server.config.max_decoding_message_size;
2024+
let max_concurrent_streams = log_server.config.grpc_max_concurrent_streams;
20242025
let shutdown_grace_period = log_server.config.grpc_shutdown_grace_period;
20252026

20262027
let wrapper = LogServerWrapper {
@@ -2030,6 +2031,7 @@ impl LogServerWrapper {
20302031
let background =
20312032
tokio::task::spawn(async move { background_server.background_task().await });
20322033
let server = Server::builder()
2034+
.max_concurrent_streams(Some(max_concurrent_streams))
20332035
.layer(chroma_tracing::GrpcServerTraceLayer)
20342036
.add_service(health_service)
20352037
.add_service(
@@ -2208,6 +2210,8 @@ pub struct LogServerConfig {
22082210
default = "LogServerConfig::default_grpc_shutdown_grace_period"
22092211
)]
22102212
pub grpc_shutdown_grace_period: Duration,
2213+
#[serde(default = "LogServerConfig::default_grpc_max_concurrent_streams")]
2214+
pub grpc_max_concurrent_streams: u32,
22112215
}
22122216

22132217
impl LogServerConfig {
@@ -2256,6 +2260,9 @@ impl LogServerConfig {
22562260
fn default_grpc_shutdown_grace_period() -> Duration {
22572261
Duration::from_secs(1)
22582262
}
2263+
fn default_grpc_max_concurrent_streams() -> u32 {
2264+
1000
2265+
}
22592266
}
22602267

22612268
impl Default for LogServerConfig {
@@ -2278,6 +2285,7 @@ impl Default for LogServerConfig {
22782285
max_encoding_message_size: Self::default_max_encoding_message_size(),
22792286
max_decoding_message_size: Self::default_max_decoding_message_size(),
22802287
grpc_shutdown_grace_period: Self::default_grpc_shutdown_grace_period(),
2288+
grpc_max_concurrent_streams: Self::default_grpc_max_concurrent_streams(),
22812289
}
22822290
}
22832291
}

0 commit comments

Comments
 (0)