Skip to content

Commit 10c6edc

Browse files
authored
[BUG] Contention in S3 gets assumed to be retryable, leading the manifest to fail. (#4888)
## Description of changes We identified this last night and I dropped it accidentally. Basically, contention at the storage layer in upload_parquet needs to fail out directly; there is no way to retry safely. ## Test plan CI ## Documentation Changes N/A
1 parent 66a25dc commit 10c6edc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

rust/wal3/src/writer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -780,7 +780,7 @@ pub async fn upload_parquet(
780780
return Ok((unprefixed_path, setsum, buffer.len()));
781781
}
782782
Err(StorageError::Precondition { path: _, source: _ }) => {
783-
return Err(Error::LogContentionRetry);
783+
return Err(Error::LogContentionFailure);
784784
}
785785
Err(err) => {
786786
if start.elapsed() > Duration::from_secs(60) {

0 commit comments

Comments
 (0)