Commit 3b7b009
[ENH] Upgrade to foyer 0.20.1 to support multi-disk (#5887)
## Description of changes
_Summarize the changes made by this PR._
- Improvements / New functionality
- Supports multi disk configuration on foyer.
- Derived from #5877 but notable improvements:
1. Actually tests the new behavior and adds logic to make it work in the
various parsing configurations.
2. Adds .with_direct() flag to match previous behavior. This was missed
in #5877
3. Adds support for clap parsing an empty default value, this ensures
memory cache which does not need this argument can be created without
needing to be specified. clap(skip) has the same behavior but this is
more explicit and thus preferred. The string parsing should tolerate
empty paths, whitespaces other misc formatting issues.
4. More helpful and descriptive error messages
5. Supports the legacy capacity: case since we now flatten capacity into
the root. And adds tests for this
- Read through foyer implementation to confirm no other regressions.
## Test plan
_How are these changes tested?_
I have test legacy config, clap parsing of new config, the new multi
disk config with single disks, and the config with multiple disks.
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust
## Migration plan
No migration should be required since we handle the legacy case.
## Observability plan
None
## Documentation Changes
None
---------
Co-authored-by: Max Isom <[email protected]>1 parent ec4af77 commit 3b7b009
File tree
8 files changed
+416
-139
lines changed- rust
- cache
- src
- bin
- frontend/src
- worker
8 files changed
+416
-139
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
0 commit comments