Skip to content

Commit 9cce6b1

Browse files
authored
[ENH] add image tags to db migration jobs (#2425)
1 parent e37a24c commit 9cce6b1

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

Tiltfile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,11 @@ k8s_resource(
131131

132132
# Production Chroma
133133
k8s_resource('postgres', resource_deps=['k8s_setup', 'namespace'], labels=["infrastructure"], port_forwards='5432:5432')
134-
k8s_resource('sysdb-migration', resource_deps=['postgres', 'namespace'], labels=["infrastructure"])
135-
k8s_resource('logservice-migration', resource_deps=['postgres', 'namespace'], labels=["infrastructure"])
136-
k8s_resource('logservice', resource_deps=['sysdb-migration'], labels=["chroma"], port_forwards='50052:50051')
137-
k8s_resource('sysdb', resource_deps=['sysdb-migration'], labels=["chroma"], port_forwards='50051:50051')
134+
# Jobs are suffixed with the image tag to ensure they are unique. In this context, the image tag is defined in k8s/distributed-chroma/values.yaml.
135+
k8s_resource('sysdb-migration-sysdb-migration', resource_deps=['postgres', 'namespace'], labels=["infrastructure"])
136+
k8s_resource('logservice-migration-logservice-migration', resource_deps=['postgres', 'namespace'], labels=["infrastructure"])
137+
k8s_resource('logservice', resource_deps=['sysdb-migration-sysdb-migration'], labels=["chroma"], port_forwards='50052:50051')
138+
k8s_resource('sysdb', resource_deps=['sysdb-migration-sysdb-migration'], labels=["chroma"], port_forwards='50051:50051')
138139
k8s_resource('frontend-service', resource_deps=['sysdb', 'logservice'],labels=["chroma"], port_forwards='8000:8000')
139140
k8s_resource('query-service', resource_deps=['sysdb'], labels=["chroma"], port_forwards='50053:50051')
140141
k8s_resource('compaction-service', resource_deps=['sysdb'], labels=["chroma"])

k8s/distributed-chroma/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ apiVersion: v2
1616
name: distributed-chroma
1717
description: A helm chart for distributed Chroma
1818
type: application
19-
version: 0.1.2
19+
version: 0.1.3
2020
appVersion: "0.4.23"
2121
keywords:
2222
- chroma

k8s/distributed-chroma/templates/log-migration.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: batch/v1
22
kind: Job
33
metadata:
4-
name: logservice-migration
4+
name: logservice-migration-{{ .Values.logServiceMigration.image.tag }}
55
namespace: {{ .Values.namespace }}
66
annotations:
77
{{ range .Values.sysdbMigration.annotations }}

k8s/distributed-chroma/templates/sysdb-migration.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: batch/v1
22
kind: Job
33
metadata:
4-
name: sysdb-migration
4+
name: sysdb-migration-{{ .Values.sysdbMigration.image.tag }}
55
namespace: {{ .Values.namespace }}
66
annotations:
77
{{ range .Values.sysdbMigration.annotations }}

0 commit comments

Comments
 (0)