Commit b11d029
authored
[BUG] Ensure arrow sizing is correct / 64 byte aligned (#2426)
## Description of changes
*Summarize the changes made by this PR.*
- Improvements & Bug fixes
- Arrow will overreport the size of a buffer if the underlying buffers
are shared (apache/arrow-rs#5969).
- apache/arrow-rs#5554 Exposes the ability to
enforce alignment at write time. This PR enables this option explicitly
and upgrades arrow to take advantage of it. We don't change from the
default alignment but this is defensive.
- See the comments in get_size() for further understanding of this PR
(https://github.com/chroma-core/chroma/pull/2426/files#diff-03bcd4f01acfa68c46fcc974d3722fa621056b4e0f908d708a2d15028b0e99b1R410)
- Cleans up various error handling and documentation - adding explicit
errors and removing panics as needed
- New functionality
- None
## Test plan
*How are these changes tested?*
Updated all tests in delta.rs to save, load and check the sizes match
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust
## Documentation Changes
None1 parent 6ffae91 commit b11d029
File tree
5 files changed
+546
-194
lines changed- rust/worker
- src/blockstore/arrow
- block
5 files changed
+546
-194
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
| |||
0 commit comments