Skip to content

Commit 488935e

Browse files
zmodemChromium LUCI CQ
authored andcommitted
Revert "Don't compile gvariant_ref_unittest.cc with ToT clang"
This reverts commit 80dcfe1. Reason for revert: The Clang issue is reported to have been fixed in llvm/llvm-project#112896 Original change's description: > Don't compile gvariant_ref_unittest.cc with ToT clang > > gvariant_ref_unittest.cc exposes a bug in clang built with asserts (llvm/llvm-project#112352) which may not be fixed soon. This breaks all of the clang ToT bots which build and use clang with asserts. Disable compiling this file under llvm_force_head_revision, which our clang ToT bots set. > > Bug: 373478542 > Change-Id: Id56cbc66c455a9480c5ceafe4fb9f0fc6e1bba02 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5941915 > Commit-Queue: Arthur Eubanks <[email protected]> > Commit-Queue: Erik Jensen <[email protected]> > Auto-Submit: Arthur Eubanks <[email protected]> > Reviewed-by: Erik Jensen <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1370344} Bug: 373478542 Change-Id: I270b0e13128c528bb5e1fe883c561d18a002551f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5954005 Reviewed-by: Erik Jensen <[email protected]> Auto-Submit: Hans Wennborg <[email protected]> Commit-Queue: Erik Jensen <[email protected]> Reviewed-by: Arthur Eubanks <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1372195}
1 parent 06b50e7 commit 488935e

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

remoting/host/linux/BUILD.gn

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
# found in the LICENSE file.
44

55
import("//build/config/c++/c++.gni")
6-
import("//build/toolchain/toolchain.gni")
76
import("//build/config/chromeos/ui_mode.gni")
87
import("//remoting/build/config/remoting_build.gni")
98

@@ -185,12 +184,6 @@ source_set("unit_tests") {
185184
"x_server_clipboard_unittest.cc",
186185
]
187186

188-
# This file causes clang to crash when clang is built with asserts.
189-
# TODO(https://crbug.com/373478542): remove workaround once clang is fixed upstream.
190-
if (llvm_force_head_revision) {
191-
sources -= [ "gvariant_ref_unittest.cc" ]
192-
}
193-
194187
if (!remoting_use_x11) {
195188
sources -= [
196189
"unicode_to_keysym_unittest.cc",

0 commit comments

Comments
 (0)