Skip to content

Commit 2e0302a

Browse files
committed
Remove a TODO comment in floats that is done
1 parent 7c99217 commit 2e0302a

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

num/__private/float_macros.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -764,8 +764,6 @@ class Array;
764764
return T::from_bits(UnsignedIntT::from_ne_bytes(bytes)); \
765765
}
766766

767-
// to_be_bytes, to_le_bytes, to_ne_bytes
768-
769767
#define _sus__float(T, PrimitiveT, UnsignedIntT) \
770768
_sus__float_storage(PrimitiveT); \
771769
_sus__float_constants(T, PrimitiveT); \

tuple/tuple.h

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,12 @@ class Tuple final {
3838
requires(I <= sizeof...(Ts))
3939
constexpr inline const auto& get() const& noexcept {
4040
::sus::check(!moved_from());
41-
return Access<I + 1>::get(storage_);
41+
return Access<I + 1u>::get(storage_);
4242
}
4343

4444
/// Disallows getting a reference to temporary Tuple.
4545
template <size_t I>
46+
requires(I <= sizeof...(Ts))
4647
constexpr inline auto get() && =
4748
delete; // Don't return reference to temporary.
4849

@@ -51,15 +52,15 @@ class Tuple final {
5152
requires(I <= sizeof...(Ts))
5253
inline auto& get_mut() & noexcept {
5354
::sus::check(!moved_from());
54-
return Access<I + 1>::get_mut(storage_);
55+
return Access<I + 1u>::get_mut(storage_);
5556
}
5657

5758
/// Returns the `I`th element in the tuple.
5859
template <size_t I>
5960
requires(I <= sizeof...(Ts))
6061
constexpr inline auto unwrap() && noexcept {
6162
::sus::check(!set_moved_from());
62-
return Access<I + 1>::unwrap(static_cast<Storage&&>(storage_));
63+
return Access<I + 1u>::unwrap(static_cast<Storage&&>(storage_));
6364
}
6465

6566
/// sus::num::Eq<Tuple<U...>> trait.
@@ -83,7 +84,7 @@ class Tuple final {
8384
::sus::check(!r.moved_from());
8485
return __private::storage_cmp(
8586
std::strong_ordering::equal, storage_, r.storage_,
86-
std::make_index_sequence<1 + sizeof...(Ts)>());
87+
std::make_index_sequence<1u + sizeof...(Ts)>());
8788
}
8889

8990
/// sus::num::WeakOrd<Tuple<U...>> trait.
@@ -96,7 +97,7 @@ class Tuple final {
9697
::sus::check(!r.moved_from());
9798
return __private::storage_cmp(
9899
std::weak_ordering::equivalent, storage_, r.storage_,
99-
std::make_index_sequence<1 + sizeof...(Ts)>());
100+
std::make_index_sequence<1u + sizeof...(Ts)>());
100101
}
101102

102103
/// sus::num::PartialOrd<Tuple<U...>> trait.
@@ -109,7 +110,7 @@ class Tuple final {
109110
::sus::check(!r.moved_from());
110111
return __private::storage_cmp(
111112
std::partial_ordering::equivalent, storage_, r.storage_,
112-
std::make_index_sequence<1 + sizeof...(Ts)>());
113+
std::make_index_sequence<1u + sizeof...(Ts)>());
113114
}
114115

115116
private:
@@ -124,10 +125,10 @@ class Tuple final {
124125

125126
// TODO: Provide a way to opt out of all moved-from checks?
126127
constexpr inline bool moved_from() const& noexcept {
127-
return Access<0>::get(storage_);
128+
return Access<0u>::get(storage_);
128129
}
129130
constexpr inline bool set_moved_from() & noexcept {
130-
return ::sus::mem::replace(mref(Access<0>::get_mut(storage_)), true);
131+
return ::sus::mem::replace(mref(Access<0u>::get_mut(storage_)), true);
131132
}
132133

133134
Storage storage_;

0 commit comments

Comments
 (0)