Merge pull request #4 from pulumi/pgavlin/test-cleanup

Author: stack72

helper/resource/testing_new_test.go

@@ -1086,7 +1086,6 @@ func TestShimState(t *testing.T) {
 	for i, tc := range testCases {
 		t.Run(fmt.Sprintf("%d-%s", i, tc.Name), func(t *testing.T) {
 			var rawState tfjson.State
-			rawState.UseJSONNumber(true)
 
 			err := json.Unmarshal([]byte(tc.RawState), &rawState)
 			if err != nil {

helper/schema/grpc_provider_test.go

@@ -688,121 +688,6 @@ func TestApplyResourceChange(t *testing.T) {
 	}
 }
 
-func TestApplyResourceChange_bigint(t *testing.T) {
-	testCases := []struct {
-		Description  string
-		TestResource *Resource
-	}{
-		{
-			Description: "Create",
-			TestResource: &Resource{
-				UseJSONNumber: true,
-				Schema: map[string]*Schema{
-					"foo": {
-						Type:     TypeInt,
-						Required: true,
-					},
-				},
-				Create: func(rd *ResourceData, _ interface{}) error {
-					rd.SetId("bar")
-					return nil
-				},
-			},
-		},
-		{
-			Description: "CreateContext",
-			TestResource: &Resource{
-				UseJSONNumber: true,
-				Schema: map[string]*Schema{
-					"foo": {
-						Type:     TypeInt,
-						Required: true,
-					},
-				},
-				CreateContext: func(_ context.Context, rd *ResourceData, _ interface{}) diag.Diagnostics {
-					rd.SetId("bar")
-					return nil
-				},
-			},
-		},
-		{
-			Description: "CreateWithoutTimeout",
-			TestResource: &Resource{
-				UseJSONNumber: true,
-				Schema: map[string]*Schema{
-					"foo": {
-						Type:     TypeInt,
-						Required: true,
-					},
-				},
-				CreateWithoutTimeout: func(_ context.Context, rd *ResourceData, _ interface{}) diag.Diagnostics {
-					rd.SetId("bar")
-					return nil
-				},
-			},
-		},
-	}
-
-	for _, testCase := range testCases {
-		testCase := testCase
-		t.Run(testCase.Description, func(t *testing.T) {
-			server := NewGRPCProviderServer(&Provider{
-				ResourcesMap: map[string]*Resource{
-					"test": testCase.TestResource,
-				},
-			})
-
-			schema := testCase.TestResource.CoreConfigSchema()
-			priorState, err := msgpack.Marshal(cty.NullVal(schema.ImpliedType()), schema.ImpliedType())
-			if err != nil {
-				t.Fatal(err)
-			}
-
-			plannedVal := cty.ObjectVal(map[string]cty.Value{
-				"id":  cty.UnknownVal(cty.String),
-				"foo": cty.MustParseNumberVal("7227701560655103598"),
-			})
-			plannedState, err := msgpack.Marshal(plannedVal, schema.ImpliedType())
-			if err != nil {
-				t.Fatal(err)
-			}
-
-			testReq := &tfprotov5.ApplyResourceChangeRequest{
-				TypeName: "test",
-				PriorState: &tfprotov5.DynamicValue{
-					MsgPack: priorState,
-				},
-				PlannedState: &tfprotov5.DynamicValue{
-					MsgPack: plannedState,
-				},
-			}
-
-			resp, err := server.ApplyResourceChange(context.Background(), testReq)
-			if err != nil {
-				t.Fatal(err)
-			}
-
-			newStateVal, err := msgpack.Unmarshal(resp.NewState.MsgPack, schema.ImpliedType())
-			if err != nil {
-				t.Fatal(err)
-			}
-
-			id := newStateVal.GetAttr("id").AsString()
-			if id != "bar" {
-				t.Fatalf("incorrect final state: %#v\n", newStateVal)
-			}
-
-			foo, acc := newStateVal.GetAttr("foo").AsBigFloat().Int64()
-			if acc != big.Exact {
-				t.Fatalf("Expected exact accuracy, got %s", acc)
-			}
-			if foo != 7227701560655103598 {
-				t.Fatalf("Expected %d, got %d, this represents a loss of precision in applying large numbers", 7227701560655103598, foo)
-			}
-		})
-	}
-}
-
 func TestPrepareProviderConfig(t *testing.T) {
 	for _, tc := range []struct {
 		Name         string

helper/schema/provider_test.go

@@ -566,7 +566,7 @@ func TestProviderDiff_timeoutInvalidValue(t *testing.T) {
 	if err == nil {
 		t.Fatal("Expected provider.Diff to fail with invalid timeout value")
 	}
-	expectedErrMsg := "time: invalid duration invalid"
+	expectedErrMsg := "time: invalid duration \"invalid\""
 	if !strings.Contains(err.Error(), expectedErrMsg) {
 		t.Fatalf("Unexpected error message: %q\nExpected message to contain %q",
 			err.Error(),