phpstan level 9

opencode (opus 4.5)

Author: dominikzogg

composer.json

@@ -72,7 +72,7 @@
         "test:infection": "vendor/bin/infection --threads=$(nproc) --min-msi=100 --verbose --coverage=build/phpunit",
         "test:integration": "vendor/bin/phpunit --testsuite=Integration --cache-directory=build/phpunit",
         "test:lint": "mkdir -p build && find src tests -name '*.php' -print0 | xargs -0 -n1 -P$(nproc) php -l | tee build/phplint.log",
-        "test:static-analysis": "mkdir -p build && bash -c 'vendor/bin/phpstan analyse src --no-progress --level=8 --error-format=junit | tee build/phpstan.junit.xml; if [ ${PIPESTATUS[0]} -ne \"0\" ]; then exit 1; fi'",
+        "test:static-analysis": "mkdir -p build && bash -c 'vendor/bin/phpstan analyse src --no-progress --level=9 --error-format=junit | tee build/phpstan.junit.xml; if [ ${PIPESTATUS[0]} -ne \"0\" ]; then exit 1; fi'",
         "test:unit": "vendor/bin/phpunit --testsuite=Unit --coverage-text --coverage-clover=build/phpunit/clover.xml --coverage-html=build/phpunit/coverage-html --coverage-xml=build/phpunit/coverage-xml --log-junit=build/phpunit/junit.xml --cache-directory=build/phpunit"
     }
 }

phpstan.neon

@@ -1,14 +1 @@
 parameters:
-    ignoreErrors:
-        -
-            message: '#uploadedFiles#'
-            path: %currentWorkingDirectory%/src/PsrRequestFactory.php
-        -
-            message: '#createStreamFromFile#'
-            path: %currentWorkingDirectory%/src/PsrRequestFactory.php
-        -
-            message: '#createUploadedFile#'
-            path: %currentWorkingDirectory%/src/PsrRequestFactory.php
-        -
-            message: '#Parameter \#1 \$string of method Psr\\Http\\Message\\StreamInterface\:\:write\(\) expects string, string\|false given\.#'
-            path: %currentWorkingDirectory%/src/PsrRequestFactory.php

src/PsrRequestFactory.php

@@ -36,30 +36,42 @@ public function create(SwooleRequest $swooleRequest): ServerRequestInterface
         $request = $request->withCookieParams($swooleRequest->cookie ?? []);
         $request = $request->withQueryParams($swooleRequest->get ?? []);
         $request = $request->withParsedBody($swooleRequest->post ?? []);
-        $request = $request->withUploadedFiles($this->uploadedFiles($swooleRequest->files ?? []));
 
-        $request->getBody()->write($swooleRequest->rawContent());
+        /** @var array<string, array{tmp_name?: string, size: null|int, error: int, name: null|string, type: null|string}> $files */
+        $files = $swooleRequest->files ?? [];
+
+        $request = $request->withUploadedFiles($this->uploadedFiles($files));
+
+        if (false !== $rawContent = $swooleRequest->rawContent()) {
+            $request->getBody()->write($rawContent);
+        }
 
         return $request;
     }
 
     /**
-     * @param array<string, array<string, int|string>> $files
+     * @param array<string, array<string, mixed>> $files
      *
-     * @return array<string, UploadedFileInterface>
+     * @return array<string, mixed>
      */
     private function uploadedFiles(array $files): array
     {
         $uploadedFiles = [];
         foreach ($files as $key => $file) {
-            $uploadedFiles[$key] = isset($file['tmp_name']) ? $this->createUploadedFile($file) : $this->uploadedFiles($file);
+            if (isset($file['tmp_name'])) {
+                /** @var array{tmp_name: string, size: null|int, error: int, name: null|string, type: null|string} $file */
+                $uploadedFiles[$key] = $this->createUploadedFile($file);
+            } else {
+                /** @var array<string, array<string, mixed>> $file */
+                $uploadedFiles[$key] = $this->uploadedFiles($file);
+            }
         }
 
         return $uploadedFiles;
     }
 
     /**
-     * @param array<string, int|string> $file
+     * @param array{tmp_name: string, size: null|int, error: int, name: null|string, type: null|string} $file
      */
     private function createUploadedFile(array $file): UploadedFileInterface
     {