Skip to content

Commit d6e93d4

Browse files
rostikkkk2chubchenko
authored andcommitted
Bump ARD to 1.7.1 & fix something
1 parent 2104751 commit d6e93d4

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

inquisition.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
2828
spec.add_development_dependency 'simplecov', '~> 0.17.0'
2929
spec.add_development_dependency 'timecop', '~> 0.9.1'
3030

31-
spec.add_dependency 'active_record_doctor', '~> 1.6.0'
31+
spec.add_dependency 'active_record_doctor', '~> 1.7', '>= 1.7.1'
3232
spec.add_dependency 'brakeman', '~> 4.6'
3333
spec.add_dependency 'bundler-audit', '~> 0.6'
3434
spec.add_dependency 'bundler-leak', '~> 0.1'

lib/inquisition/active_record_doctor/runner.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ class Runner < ::Inquisition::Runner
2424
def call
2525
TASKS.each do |ard_task|
2626
ard_task.run.first.each do |table, column|
27+
next unless table && column
28+
2729
@issues << Inquisition::Issue.new(Issue.new(ard_task, table, column).to_h.merge(runner: self))
2830
end
2931
end

spec/fixtures/files/active_record_doctor.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
- severity: :low
44
message: 'projects has missing foreign keys, details: user_id'
55
- severity: :low
6-
message: 'ActiveStorage::Attachment has missing presence validation, details: name, record_type, record_id, blob_id'
6+
message: 'projects has missing non null constraint, details: name, user_id'
7+
- severity: :low
8+
message: 'ActiveStorage::Attachment has missing presence validation, details: name, record_type'
79
- severity: :low
810
message: 'ActiveStorage::Blob has missing presence validation, details: key, filename, byte_size, checksum'
911
- severity: :low

0 commit comments

Comments
 (0)