Skip to content

Commit a475bcc

Browse files
Merge pull request docker-archive#411 from docker/ddc-dynamic
Added support for dynamic DDC generation
2 parents 06117b4 + 3ddf7fd commit a475bcc

File tree

9 files changed

+268
-49
lines changed

9 files changed

+268
-49
lines changed

Makefile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ CHANNEL_CLOUD := alpha
88
DOCKER_EXPERIMENTAL := 1
99
VHD_SKU := docker4azure
1010
VHD_VERSION := 1.12.18
11+
# stage offer will have the -preview
12+
OFFER_ID := docker4azure
13+
CS_VHD_SKU := docker4azure-cs-1_12
14+
CS_VHD_VERSION := 1.0.1
15+
# stage offer will have the -preview
16+
CS_OFFER_ID := docker4azure-cs-preview
1117
export
1218

1319
release: moby/alpine/cloud/aws/ami_id.out moby/alpine/cloud/azure/vhd_blob_url.out dockerimages

azure/dockerfiles/files/ddc-init/entry.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ echo "REGION=$REGION"
1414
echo "RGROUP_NAME=$RGROUP_NAME"
1515
echo "APP_ID=$APP_ID"
1616
echo "TENANT_ID=$TENANT_ID"
17-
echo "LB_NAME=$LB_NAME"
18-
echo "LB_IP=$LB_IP"
1917
echo "UCP_ADMIN_USER=$UCP_ADMIN_USER"
2018
echo "UCP_IMAGE=${HUB_NAMESPACE}/ucp:${HUB_TAG}"
2119
echo "#================"

azure/release/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ build:
99
docker build -t azure-release .
1010

1111
template: clean build
12-
docker run -ti --rm -v $(PWD)/dist:/home/docker/dist/ azure-release --docker_version="$(EDITIONS_DOCKER_VERSION)" --edition_version="$(EDITIONS_VERSION)" --vhd_sku="$(VHD_SKU)" --vhd_version="$(VHD_VERSION)" --channel="$(CHANNEL)" --channel_cloud="$(CHANNEL_CLOUD)"
12+
docker run -ti --rm -v $(PWD)/dist:/home/docker/dist/ azure-release --docker_version="$(EDITIONS_DOCKER_VERSION)" --edition_version="$(EDITIONS_VERSION)" --vhd_sku="$(VHD_SKU)" --vhd_version="$(VHD_VERSION)" --channel="$(CHANNEL)" --channel_cloud="$(CHANNEL_CLOUD)" --channel_ddc="$(CHANNEL_DDC)" --cs_vhd_sku="$(CS_VHD_SKU)" --cs_vhd_version="$(CS_VHD_VERSION)" --cs_offer_id="$(CS_OFFER_ID)"
1313

1414
release: clean build
15-
docker run -ti --rm -v $(PWD)/dist:/home/docker/dist/ azure-release --upload --docker_version="$(EDITIONS_DOCKER_VERSION)" --edition_version="$(EDITIONS_VERSION)" --vhd_sku="$(VHD_SKU)" --vhd_version="$(VHD_VERSION)" --channel="$(CHANNEL)" --channel_cloud="$(CHANNEL_CLOUD)"
15+
docker run -ti --rm -v $(PWD)/dist:/home/docker/dist/ azure-release --upload --docker_version="$(EDITIONS_DOCKER_VERSION)" --edition_version="$(EDITIONS_VERSION)" --vhd_sku="$(VHD_SKU)" --vhd_version="$(VHD_VERSION)" --channel="$(CHANNEL)" --channel_cloud="$(CHANNEL_CLOUD)" --channel_ddc="$(CHANNEL_DDC)" --cs_vhd_sku="$(CS_VHD_SKU)" --cs_vhd_version="$(CS_VHD_VERSION)" --cs_offer_id="$(CS_OFFER_ID)"
1616

1717
clean:
1818
# rm -f tmp/*

azure/release/files/custom-data_manager.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ docker run --log-driver=json-file --restart=no -d -e ROLE="$ROLE" -e REGION="$R
2525
docker run --log-driver=json-file --restart=always -d -e ROLE="$ROLE" -e REGION="$REGION" -e TENANT_ID="$TENANT_ID" -e APP_ID="$APP_ID" -e APP_SECRET="$APP_SECRET" -e ACCOUNT_ID="$ACCOUNT_ID" -e GROUP_NAME="$GROUP_NAME" -e PRIVATE_IP="$MANAGER_IP" -e DOCKER_FOR_IAAS_VERSION="$DOCKER_FOR_IAAS_VERSION" -e SWARM_INFO_TABLE="$SWARM_INFO_TABLE" -e SWARM_INFO_STORAGE_ACCOUNT="$SWARM_INFO_STORAGE_ACCOUNT" -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -v /var/log:/var/log docker4x/guide-azure:"$DOCKER_FOR_IAAS_VERSION"
2626
echo default: "$LB_NAME" >> /var/lib/docker/swarm/elb.config
2727
echo "$LB_NAME" > /var/lib/docker/swarm/lb_name
28-
docker run --log-driver=json-file -v /var/run/docker.sock:/var/run/docker.sock -v /var/lib/docker/swarm:/var/lib/docker/swarm --name=editions_controller docker4x/l4controller-azure:"$DOCKER_FOR_IAAS_VERSION" run --ad_app_id="$APP_ID" --ad_app_secret="$APP_SECRET" --subscription_id="$SUB_ID" --resource_group="$GROUP_NAME" --log=4 --default_lb_name="$LB_NAME" --environment=AzurePublicCloud
28+
docker run -d --log-driver=json-file -v /var/run/docker.sock:/var/run/docker.sock -v /var/lib/docker/swarm:/var/lib/docker/swarm --name=editions_controller docker4x/l4controller-azure:"$DOCKER_FOR_IAAS_VERSION" run --ad_app_id="$APP_ID" --ad_app_secret="$APP_SECRET" --subscription_id="$SUB_ID" --resource_group="$GROUP_NAME" --log=4 --default_lb_name="$LB_NAME" --environment=AzurePublicCloud

azure/release/files/custom-data_manager_cloud.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ docker run --restart=no -d -e ROLE="$ROLE" -e REGION="$REGION" -e TENANT_ID="$TE
1919
docker run --restart=always -d -e ROLE="$ROLE -e REGION="$REGION -e ACCOUNT_ID="$ACCOUNT_ID" -e PRIVATE_IP="$MANAGER_IP" -e DOCKER_FOR_IAAS_VERSION="$DOCKER_FOR_IAAS_VERSION" -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker docker4x/guide-azure:"$DOCKER_FOR_IAAS_VERSION"
2020
echo default: "$LB_NAME" >> /var/lib/docker/swarm/elb.config
2121
echo "$LB_NAME" > /var/lib/docker/swarm/lb_name
22-
docker run -v /var/run/docker.sock:/var/run/docker.sock -v /var/lib/docker/swarm:/var/lib/docker/swarm --name=editions_controller docker4x/l4controller-azure:"$DOCKER_FOR_IAAS_VERSION" run --ad_app_id="$APP_ID" --ad_app_secret="$APP_SECRET" --subscription_id="$SUB_ID" --resource_group="$GROUP_NAME" --log=4 --default_lb_name="$LB_NAME" --environment=AzurePublicCloud
22+
docker run -d -v /var/run/docker.sock:/var/run/docker.sock -v /var/lib/docker/swarm:/var/lib/docker/swarm --name=editions_controller docker4x/l4controller-azure:"$DOCKER_FOR_IAAS_VERSION" run --ad_app_id="$APP_ID" --ad_app_secret="$APP_SECRET" --subscription_id="$SUB_ID" --resource_group="$GROUP_NAME" --log=4 --default_lb_name="$LB_NAME" --environment=AzurePublicCloud
2323

2424

2525

azure/release/files/custom-data_manager_ddc.sh

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,29 +8,28 @@ export LB_NAME="variables('lbName')"
88
export APP_ID="variables('adServicePrincipalAppID')"
99
export APP_SECRET="variables('adServicePrincipalAppSecret')"
1010
export TENANT_ID="variables('adServicePrincipalTenantID')"
11-
1211
export DDC_USER="variables('ddcUser')"
1312
export DDC_PASS="variables('ddcPass')"
14-
export RGROUP_NAME="variables('groupName')";
15-
export LB_NAME="variables('lbPublicIPAddressName')";
16-
17-
18-
19-
20-
docker run --restart=no -d -e ROLE="$ROLE" -e REGION="$REGION" -e ACCOUNT_ID="$ACCOUNT_ID" -e PRIVATE_IP="$MANAGER_IP" -e DOCKER_FOR_IAAS_VERSION="$DOCKER_FOR_IAAS_VERSION" -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -v /var/log:/var/log docker4x/init-azure:"$DOCKER_FOR_IAAS_VERSION"
21-
docker run --restart=always -d -e ROLE="$ROLE -e REGION="$REGION -e ACCOUNT_ID="$ACCOUNT_ID" -e PRIVATE_IP="$MANAGER_IP" -e DOCKER_FOR_IAAS_VERSION="$DOCKER_FOR_IAAS_VERSION" -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker docker4x/guide-azure:"$DOCKER_FOR_IAAS_VERSION"
13+
export RGROUP_NAME="variables('groupName')";
14+
export SWARM_INFO_TABLE="variables('swarmInfoTable')"
15+
export SWARM_INFO_STORAGE_ACCOUNT="variables('swarmInfoStorageAccount')"
16+
export SWARM_LOGS_STORAGE_ACCOUNT="variables('swarmLogsStorageAccount')"
17+
export MANAGER_IP=$(ifconfig eth0 | grep "inet addr:" | cut -d: -f2 | cut -d" " -f1)
18+
# create daemon config with custom tag
19+
echo "{\"log-driver\": \"syslog\",\"log-opts\": {\"syslog-address\": \"udp://localhost:514\", \"tag\": \"{{.Name}}/{{.ID}}\" }}" > /etc/docker/daemon.json
20+
service docker restart
21+
sleep 5
22+
23+
# add logging container
24+
docker volume create --name container-logs
25+
docker run --log-driver=json-file --name=editions_logger --restart=always -d -e ROLE="$ROLE" -e REGION="$REGION" -e TENANT_ID="$TENANT_ID" -e APP_ID="$APP_ID" -e APP_SECRET="$APP_SECRET" -e ACCOUNT_ID="$ACCOUNT_ID" -e GROUP_NAME="$GROUP_NAME" -e SWARM_LOGS_STORAGE_ACCOUNT="$SWARM_LOGS_STORAGE_ACCOUNT" -e SWARM_FILE_SHARE=`hostname` -p 514:514/udp -v container-logs:/log/ docker4x/logger-azure:"$DOCKER_FOR_IAAS_VERSION"
26+
27+
docker run --log-driver=json-file --restart=no -d -e ROLE="$ROLE" -e REGION="$REGION" -e TENANT_ID="$TENANT_ID" -e APP_ID="$APP_ID" -e APP_SECRET="$APP_SECRET" -e ACCOUNT_ID="$ACCOUNT_ID" -e GROUP_NAME="$GROUP_NAME" -e PRIVATE_IP="$MANAGER_IP" -e DOCKER_FOR_IAAS_VERSION="$DOCKER_FOR_IAAS_VERSION" -e SWARM_INFO_TABLE="$SWARM_INFO_TABLE" -e SWARM_INFO_STORAGE_ACCOUNT="$SWARM_INFO_STORAGE_ACCOUNT" -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -v /var/log:/var/log docker4x/init-azure:"$DOCKER_FOR_IAAS_VERSION"
28+
docker run --log-driver=json-file --restart=always -d -e ROLE="$ROLE" -e REGION="$REGION" -e TENANT_ID="$TENANT_ID" -e APP_ID="$APP_ID" -e APP_SECRET="$APP_SECRET" -e ACCOUNT_ID="$ACCOUNT_ID" -e GROUP_NAME="$GROUP_NAME" -e PRIVATE_IP="$MANAGER_IP" -e DOCKER_FOR_IAAS_VERSION="$DOCKER_FOR_IAAS_VERSION" -e SWARM_INFO_TABLE="$SWARM_INFO_TABLE" -e SWARM_INFO_STORAGE_ACCOUNT="$SWARM_INFO_STORAGE_ACCOUNT" -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -v /var/log:/var/log docker4x/guide-azure:"$DOCKER_FOR_IAAS_VERSION"
2229
echo default: "$LB_NAME" >> /var/lib/docker/swarm/elb.config
2330
echo "$LB_NAME" > /var/lib/docker/swarm/lb_name
24-
docker run -v /var/run/docker.sock:/var/run/docker.sock -v /var/lib/docker/swarm:/var/lib/docker/swarm --name=editions_controller docker4x/l4controller-azure:"$DOCKER_FOR_IAAS_VERSION" run --ad_app_id="$APP_ID" --ad_app_secret="$APP_SECRET" --subscription_id="$SUB_ID" --resource_group="$GROUP_NAME" --log=4 --default_lb_name="$LB_NAME" --environment=AzurePublicCloud
25-
26-
27-
28-
export IS_LEADER=$(docker node inspect self -f "{{ .ManagerStatus.Leader }}")
29-
if [ "$IS_LEADER" == "true" ]; then
30-
docker run --rm --name=cloud_registration -v /var/run/docker.sock:/var/run/docker.sock -e DOCKER_USER="$CLOUD_USER" -e DOCKER_PASS="$CLOUD_KEY" -e SWARM_NAME="$SWARM_NAME" -e INTERNAL_ENDPOINT="$LB_SSH_IP:2376" docker4x/cloud-azure:$DOCKER_FOR_IAAS_VERSION
31-
fi
32-
3331

32+
docker run --log-driver=json-file --restart=no --rm -e ROLE=$ROLE -e REGION=$REGION -e ACCOUNT_ID=$ACCOUNT_ID -e APP_ID=$APP_ID -e APP_SECRET=$APP_SECRET -e TENANT_ID=$TENANT_ID -e RGROUP_NAME=$RGROUP_NAME -e UCP_ADMIN_USER=$DDC_USER -e UCP_ADMIN_PASSWORD=$DDC_PASS -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker docker4x/ddc-init-azure:$DOCKER_FOR_IAAS_VERSION
3433

35-
docker run --restart=no --rm -e ROLE=$ROLE -e REGION=$REGION -e ACCOUNT_ID=$ACCOUNT_ID -e APP_ID=$APP_ID -e APP_SECRET=$APP_SECRET -e TENANT_ID=$TENANT_ID -e RGROUP_NAME=$RGROUP_NAME -e UCP_ADMIN_USER=$DDC_USER -e UCP_ADMIN_PASSWORD=$DDC_PASS -e LB_NAME=$LB_NAME -e LB_IP=$LB_SSH_IP -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker docker4x/ddc-init-azure:$DOCKER_FOR_IAAS_VERSION
34+
docker run -d --log-driver=json-file -v /var/run/docker.sock:/var/run/docker.sock -v /var/lib/docker/swarm:/var/lib/docker/swarm --name=editions_controller docker4x/l4controller-azure:"$DOCKER_FOR_IAAS_VERSION" run --ad_app_id="$APP_ID" --ad_app_secret="$APP_SECRET" --subscription_id="$SUB_ID" --resource_group="$GROUP_NAME" --log=4 --default_lb_name="$LB_NAME" --environment=AzurePublicCloud
3635

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
export ROLE="WORKER"
2+
export REGION="variables('storageLocation')"
3+
export ACCOUNT_ID="variables('accountID')"
4+
export DOCKER_FOR_IAAS_VERSION="variables('dockerForIAASVersion')"
5+
export GROUP_NAME="variables('groupName')"
6+
export APP_ID="variables('adServicePrincipalAppID')"
7+
export APP_SECRET="variables('adServicePrincipalAppSecret')"
8+
export TENANT_ID="variables('adServicePrincipalTenantID')"
9+
export SWARM_INFO_TABLE="variables('swarmInfoTable')"
10+
export SWARM_INFO_STORAGE_ACCOUNT="variables('swarmInfoStorageAccount')"
11+
export SWARM_LOGS_STORAGE_ACCOUNT="variables('swarmLogsStorageAccount')"
12+
13+
# create daemon config with custom tag
14+
echo "{\"log-driver\": \"syslog\",\"log-opts\": {\"syslog-address\": \"udp://localhost:514\", \"tag\": \"{{.Name}}/{{.ID}}\" }}" > /etc/docker/daemon.json
15+
service docker restart
16+
sleep 5
17+
18+
# add logging container
19+
docker volume create --name container-logs
20+
docker run --log-driver=json-file --name=editions_logger --restart=always -d -e ROLE="$ROLE" -e REGION="$REGION" -e TENANT_ID="$TENANT_ID" -e APP_ID="$APP_ID" -e APP_SECRET="$APP_SECRET" -e ACCOUNT_ID="$ACCOUNT_ID" -e GROUP_NAME="$GROUP_NAME" -e SWARM_LOGS_STORAGE_ACCOUNT="$SWARM_LOGS_STORAGE_ACCOUNT" -e SWARM_FILE_SHARE=`hostname` -p 514:514/udp -v container-logs:/log/ docker4x/logger-azure:"$DOCKER_FOR_IAAS_VERSION"
21+
22+
docker run --log-driver=json-file --restart=no -d -e ROLE=$ROLE -e REGION=$REGION -e TENANT_ID="$TENANT_ID" -e APP_ID="$APP_ID" -e APP_SECRET="$APP_SECRET" -e GROUP_NAME="$GROUP_NAME" -e SWARM_INFO_TABLE="$SWARM_INFO_TABLE" -e SWARM_INFO_STORAGE_ACCOUNT="$SWARM_INFO_STORAGE_ACCOUNT" -e ACCOUNT_ID=$ACCOUNT_ID -e MANAGER_IP=$MANAGER_IP -e DOCKER_FOR_IAAS_VERSION=$DOCKER_FOR_IAAS_VERSION -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -v /var/log:/var/log docker4x/init-azure:$DOCKER_FOR_IAAS_VERSION
23+
docker run --log-driver=json-file --restart=no --rm -e ROLE=$ROLE -e REGION=$REGION -e ACCOUNT_ID=$ACCOUNT_ID -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker docker4x/ddc-init-azure:$DOCKER_FOR_IAAS_VERSION
24+
25+
docker run --log-driver=json-file --restart=always -d -e ROLE=$ROLE -e REGION=$REGION -e ACCOUNT_ID=$ACCOUNT_ID -e MANAGER_IP=$MANAGER_IP -e DOCKER_FOR_IAAS_VERSION=$DOCKER_FOR_IAAS_VERSION -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker docker4x/guide-azure:$DOCKER_FOR_IAAS_VERSION

azure/release/files/release.py

Lines changed: 32 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import json
33
import argparse
44

5-
from utils import (create_rg_template, create_rg_cloud_template, upload_rg_template)
5+
from utils import (create_rg_template, create_rg_cloud_template, create_rg_ddc_template, upload_rg_template)
66

77

88
CFN_TEMPLATE = '/home/docker/editions.template'
@@ -27,38 +27,66 @@ def main():
2727
parser.add_argument('-u', '--channel_cloud',
2828
dest='channel_cloud', default="alpha",
2929
help="Cloud release channel (beta, alpha, rc, nightly)")
30+
parser.add_argument('--channel_ddc',
31+
dest='channel_ddc', default="alpha",
32+
help="DDC release channel (beta, alpha, rc, nightly)")
33+
parser.add_argument('--offer_id',
34+
dest='offer_id', default="docker4azure",
35+
help="The Azure VHD Offer ID")
36+
parser.add_argument('--cs_vhd_sku',
37+
dest='cs_vhd_sku',
38+
help="The Azure CS VHD SKU (i.e. docker4azure)")
39+
parser.add_argument('--cs_vhd_version',
40+
dest='cs_vhd_version',
41+
help="The Azure CS VHD version (i.e. 1.0.0)")
42+
parser.add_argument('--cs_offer_id',
43+
dest='cs_offer_id',
44+
help="The Azure CS VHD Offer ID")
3045
parser.add_argument("--upload", action="store_true",
3146
help="Upload the Azure template once generated")
3247

3348
args = parser.parse_args()
3449

3550
release_channel = args.channel
3651
release_cloud_channel = args.channel_cloud
52+
release_ddc_channel = args.channel_cloud
3753
docker_version = args.docker_version
3854
# TODO change to something else? where to get moby version?
3955
moby_version = docker_version
4056
edition_version = args.edition_version
4157
flat_edition_version = edition_version.replace(" ", "")
4258
vhd_sku = args.vhd_sku
4359
vhd_version = args.vhd_version
60+
offer_id = args.offer_id
61+
cs_vhd_sku = args.cs_vhd_sku
62+
cs_vhd_version = args.cs_vhd_version
63+
cs_offer_id = args.cs_offer_id
64+
4465
docker_for_azure_version = u"azure-v{}".format(flat_edition_version)
4566
image_name = u"Moby Linux {}".format(docker_for_azure_version)
4667
image_description = u"The best OS for running Docker, version {}".format(moby_version)
4768
print("\n Variables")
4869
print(u"release_channel={}".format(release_channel))
4970
print(u"release_cloud_channel={}".format(release_cloud_channel))
71+
print(u"release_ddc_channel={}".format(release_ddc_channel))
5072
print(u"docker_version={}".format(docker_version))
5173
print(u"edition_version={}".format(edition_version))
5274
print(u"vhd_sku={}".format(vhd_sku))
5375
print(u"vhd_version={}".format(vhd_version))
76+
print(u"cs_vhd_sku={}".format(cs_vhd_sku))
77+
print(u"cs_vhd_version={}".format(cs_vhd_version))
5478

5579
print("Create CloudFormation template..")
5680
template_name = u"{}.json".format(docker_for_azure_version)
57-
base_url = create_rg_template(vhd_sku, vhd_version, release_channel, docker_version,
81+
base_url = create_rg_template(vhd_sku, vhd_version, offer_id, release_channel, docker_version,
5882
docker_for_azure_version, edition_version, CFN_TEMPLATE, template_name)
5983
cloud_template_name = u"{}-cloud.json".format(docker_for_azure_version)
6084
cloud_url = create_rg_cloud_template(release_cloud_channel, docker_version,
6185
docker_for_azure_version, edition_version, base_url, cloud_template_name)
86+
87+
ddc_template_name = u"{}-ddc.json".format(docker_for_azure_version)
88+
ddc_url = create_rg_ddc_template(cs_vhd_sku, cs_vhd_version, cs_offer_id, release_ddc_channel, docker_version,
89+
docker_for_azure_version, edition_version, base_url, ddc_template_name)
6290

6391
print("------------------")
6492
print(u"Finshed.. \n")
@@ -67,7 +95,8 @@ def main():
6795
print(u"Uploading templates.. \n")
6896
s3_url = upload_rg_template(release_channel, template_name, base_url)
6997
s3_cloud_url = upload_rg_template(release_channel, cloud_template_name, cloud_url)
70-
print(u"Uploaded CloudFormation \n\t URL={0} \n\t CLOUD_URL={1} \n".format(s3_url, s3_cloud_url))
98+
s3_ddc_url = upload_rg_template(release_channel, ddc_template_name, ddc_url)
99+
print(u"Uploaded CloudFormation \n\t URL={0} \n\t CLOUD_URL={1} \n\t DDC_URL={2} \n".format(s3_url, s3_cloud_url, s3_ddc_url))
71100

72101
# TODO: git commit, tag release. requires github keys, etc.
73102
print("Don't forget to tag the code (git tag -a v{0}-{1} -m {0}; git push --tags)".format(

0 commit comments

Comments
 (0)