Merge pull request docker-archive#432 from nathanleclaire/azure_diagnostics_server

Add support for diagnostics-server to Azure

Author: nathanleclaire

aws/dockerfiles/files/bin/docker-diagnose

@@ -1,7 +1,54 @@
 #!/bin/sh
 
+set -e
+
 DIAGNOSTICS_MAGIC_PORT=44554
-NODES=$(docker node inspect $(docker node ls -q) | jq -r '.[] | .Description.Hostname' | tr '\n' ' ')
+
+platform()
+{
+	# TODO: This will need to be changed if the current configuration of
+	# system containers are not invoked via 'docker run' anymore
+	#
+	# (and/or might be more elegant to pass in the platform via environment
+	# variables, etc.)
+	PLATFORM=$(docker images | grep aws)
+	if [ $? -eq 0 ]
+		echo "aws"
+	then
+		echo "azure"
+	fi
+}
+
+node_hostnames()
+{
+	docker node inspect $(docker node ls -q) | jq -r '.[] | .Description.Hostname'
+}
+
+azure_resolver()
+{
+	# Sample /etc/resolv.conf on Azure:
+	#
+	# # Generated by dhcpcd from eth0.dhcp
+	# # /etc/resolv.conf.head can replace this line
+	# domain zopqyteo2tpuxc1cyzroivpijh.gx.internal.cloudapp.net
+	# nameserver 168.63.129.16
+	# # /etc/resolv.conf.tail can replace this line
+	#
+	cat /etc/resolv.conf | grep domain | awk '{ print $2; }'
+}
+
+if [ "$(platform)" = "aws" ]
+then
+	NODES=$(node_hostnames)
+else
+	# We need to append to the hostnames with the DNS resolver address, or
+	# else they won't resolve properly.
+	#
+	# We could potentially modify swarm to accept a "hostname" (more
+	# properly nodename) type flag on join, but no such option seems
+	# available today.
+	NODES=$(node_hostnames | sed -e "s/$/.$(azure_resolver)/")
+fi
 
 # Session is set to a pseudo-random string combined with the current timestamp.
 # This should minimize the probability of collision while also providing

azure/dockerfiles/walinuxagent/Dockerfile

@@ -20,7 +20,7 @@ RUN apk add --no-cache --update \
 
 # Windows Azure Linux agent section
 RUN pip install pyasn1
-ENV AGENT_REVISION ef3d68857cf08b65bbe7dfeb7a811cc9f1aa5bc1
+ENV AGENT_REVISION 5d66b1c923fcccf1f00b6004627f7f3d46172142
 
 # TODO: Move back to upstream (a PR is out for this on the Azure agent --
 # https://github.com/Azure/WALinuxAgent/pull/341), for now we have to use this
@@ -35,7 +35,7 @@ RUN cp bin/* /usr/sbin/
 # TODO: If upstream shell Dockerfile changes this will also need to be changed.
 # Should be implemented more elegantly.
 RUN mkdir /daemons && \
-    mv /entry.sh /daemons/sshd-entrypoint.sh && \
+    rm /entry.sh && \
     mv /etc/ssh/sshd_config /opt/sshd_config && \
     mv /etc/motd /opt/motd
 

azure/dockerfiles/walinuxagent/Makefile

@@ -1,7 +1,9 @@
+TAG := latest
+
 default: build
 
 build:
-	docker build -t docker4x/agent-azure .
+	docker build -t docker4x/agent-azure:$(TAG) .
 
 push: build
-	docker push docker4x/agent-azure
+	docker push docker4x/agent-azure:$(TAG)

azure/dockerfiles/walinuxagent/supervisord.conf

@@ -11,7 +11,7 @@ user=root
 childlogdir=/var/log/
 
 [program:sshd]
-command=bash -c "sleep 5; /daemons/sshd-entrypoint.sh /usr/sbin/sshd -D -f /etc/ssh/sshd_config"
+command=bash -c "sleep 5; /usr/sbin/sshd -D -f /etc/ssh/sshd_config"
 startretries=100
 autorestart=true
 

azure/templates/editions.template.json

@@ -350,6 +350,20 @@
               "direction": "Inbound"
             }
           },
+          {
+            "name": "diagnostics",
+            "properties": {
+              "description": "Allow communication for the diagnostics server",
+              "protocol": "Tcp",
+              "sourcePortRange": "*",
+              "destinationPortRange": "44554",
+              "sourceAddressPrefix": "[variables('subnetPrefix')]",
+              "destinationAddressPrefix": "[variables('subnetPrefix')]",
+              "access": "Allow",
+              "priority": 205,
+              "direction": "Inbound"
+            }
+          },
           {
             "name": "docker-port",
             "properties": {
@@ -360,7 +374,7 @@
               "sourceAddressPrefix": "[variables('subnetPrefix')]",
               "destinationAddressPrefix": "[variables('subnetPrefix')]",
               "access": "Allow",
-              "priority": 205,
+              "priority": 206,
               "direction": "Inbound"
             }
           }