test(cloudformation): Added CFN LSP E2E tests to PR runners (aws#8379)

## Description
- Added existing E2E tests to PR runners for `MacOS`, `Ubuntu` and
`Windows`
- Configured LSP server to be pre downloaded before the tests starts
using the manifest and added a fallback to download directly from Github
releases
- Printing extension logs in the test runners if there are test failures
---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

---------

Co-authored-by: Deep Furiya <[email protected]>

Author: deepfuriya

.github/workflows/node.js.yml

@@ -181,6 +181,67 @@ jobs:
               with:
                   run: npm run testWeb
 
+    cloudformation-integ:
+        needs: lint-commits
+        name: CloudFormation LSP E2E Tests
+        runs-on: ${{ matrix.os }}
+        strategy:
+            fail-fast: false
+            matrix:
+                os: [ubuntu-latest, macos-latest, windows-latest]
+                node-version: [18.x]
+                vscode-version: [stable]
+        env:
+            VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
+            NODE_OPTIONS: '--max-old-space-size=8192'
+        steps:
+            - uses: actions/checkout@v4
+            - name: Use Node.js ${{ matrix.node-version }}
+              uses: actions/setup-node@v4
+              with:
+                  node-version: ${{ matrix.node-version }}
+            - name: Setup CloudFormation LSP
+              shell: bash
+              run: bash packages/core/src/testE2E/cloudformation/setup-local-lsp.sh
+            - run: npm ci
+            - name: Run CloudFormation E2E Tests (Unix)
+              if: runner.os != 'Windows'
+              uses: coactions/setup-xvfb@v1
+              with:
+                  run: npm run testE2ECfn -w packages/toolkit
+            - name: Run CloudFormation E2E Tests (Windows)
+              if: runner.os == 'Windows'
+              run: npm run testE2ECfn -w packages/toolkit
+            - name: Print Extension Logs
+              if: failure()
+              shell: bash
+              run: |
+                  echo "=== AWS Toolkit Extension Logs ==="
+                  find packages/toolkit/.vscode-test/user-data/logs -name "*.log" -type f 2>/dev/null | while read logfile; do
+                    echo "--- $logfile ---"
+                    cat "$logfile" || echo "Could not read log file"
+                  done || echo "No extension logs found"
+
+                  echo ""
+                  echo "=== CloudFormation LSP Server Logs ==="
+                  echo "LSP Path: $__CLOUDFORMATIONLSP_PATH"
+                  if [ -n "$__CLOUDFORMATIONLSP_PATH" ]; then
+                    LSP_LOG_DIR="$__CLOUDFORMATIONLSP_PATH/.aws-cfn-storage/logs"
+                    echo "Checking directory: $LSP_LOG_DIR"
+                    if [ -d "$LSP_LOG_DIR" ]; then
+                      find "$LSP_LOG_DIR" -name "*.log" -type f 2>/dev/null | while read logfile; do
+                        echo "--- $logfile ---"
+                        cat "$logfile" || echo "Could not read log file"
+                      done
+                    else
+                      echo "LSP logs directory does not exist: $LSP_LOG_DIR"
+                      echo "Contents of LSP path:"
+                      ls -la "$__CLOUDFORMATIONLSP_PATH" 2>/dev/null || echo "Cannot list LSP path"
+                    fi
+                  else
+                    echo "Environment variable __CLOUDFORMATIONLSP_PATH is not set"
+                  fi
+
     windows:
         needs: lint-commits
         name: test Windows

packages/core/src/testE2E/cloudformation/setup-local-lsp.sh

@@ -22,6 +22,7 @@ ARCH=$(uname -m)
 case "$OS" in
     darwin) PLATFORM="darwin" ;;
     linux) PLATFORM="linux" ;;
+    mingw*|msys*|cygwin*) PLATFORM="win32" ;;
     *) echo "Unsupported OS: $OS"; exit 1 ;;
 esac
 
@@ -35,13 +36,31 @@ NODE_VERSION="22"
 
 # Fetch latest release
 echo "Fetching latest LSP server release..."
-RELEASE_URL="https://api.github.com/repos/aws-cloudformation/cloudformation-languageserver/releases/latest"
-DOWNLOAD_URL=$(curl -s "$RELEASE_URL" | grep "browser_download_url.*${PLATFORM}-${ARCH}-node${NODE_VERSION}.zip" | cut -d'"' -f4 | head -1)
+MANIFEST_URL="https://raw.githubusercontent.com/aws-cloudformation/cloudformation-languageserver/main/assets/release-manifest.json"
+
+# Try manifest first
+if command -v jq &> /dev/null; then
+    echo "Trying manifest: $MANIFEST_URL"
+    DOWNLOAD_URL=$(curl -s "$MANIFEST_URL" | jq -r ".prod[] | select(.latest == true) | .targets[] | select(.platform == \"$PLATFORM\" and .arch == \"$ARCH\" and .nodejs == \"$NODE_VERSION\") | .contents[0].url")
+    if [ -n "$DOWNLOAD_URL" ]; then
+        echo "✓ Using manifest URL"
+    fi
+else
+    echo "jq not available, skipping manifest"
+fi
+
+# Fallback to GitHub API if manifest fails
+if [ -z "$DOWNLOAD_URL" ]; then
+    echo "Trying GitHub API fallback..."
+    RELEASE_URL="https://api.github.com/repos/aws-cloudformation/cloudformation-languageserver/releases/latest"
+    DOWNLOAD_URL=$(curl -s "$RELEASE_URL" | grep "browser_download_url.*${PLATFORM}-${ARCH}-node${NODE_VERSION}.zip" | cut -d'"' -f4 | head -1)
+    if [ -n "$DOWNLOAD_URL" ]; then
+        echo "✓ Using GitHub API URL"
+    fi
+fi
 
 if [ -z "$DOWNLOAD_URL" ]; then
     echo "Error: Could not find LSP server release for ${PLATFORM}-${ARCH}-node${NODE_VERSION}"
-    echo "Available releases:"
-    curl -s "$RELEASE_URL" | grep "browser_download_url" | cut -d'"' -f4
     exit 1
 fi
 
@@ -78,5 +97,20 @@ done
 echo ""
 echo "✓ LSP server ready at: $LSP_SERVER_DIR"
 echo ""
+
+# Export to GitHub Actions environment if running in CI
+if [ -n "$GITHUB_ENV" ]; then
+    # Convert to Windows path format if on Windows
+    if [[ "$PLATFORM" == "win32" ]]; then
+        # Convert /d/path to D:/path format for Node.js on Windows
+        WIN_PATH=$(echo "$LSP_SERVER_DIR" | sed 's|^/\([a-z]\)/|\U\1:/|')
+        echo "__CLOUDFORMATIONLSP_PATH=$WIN_PATH" >> "$GITHUB_ENV"
+        echo "Exported __CLOUDFORMATIONLSP_PATH=$WIN_PATH to GitHub Actions environment"
+    else
+        echo "__CLOUDFORMATIONLSP_PATH=$LSP_SERVER_DIR" >> "$GITHUB_ENV"
+        echo "Exported __CLOUDFORMATIONLSP_PATH=$LSP_SERVER_DIR to GitHub Actions environment"
+    fi
+fi
+
 echo "Run tests with:"
 echo "__CLOUDFORMATIONLSP_PATH=\"$LSP_SERVER_DIR\" npm run testE2E -w packages/toolkit"