Skip to content

Support post data on PATCH requests in OAuth2 #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support post data on PATCH requests in OAuth2 #314

wants to merge 1 commit into from

Conversation

jankeromnes
Copy link

Some OAuth2-enabled APIs use the PATCH HTTP verb (for example GitHub's API) combined with a body to update an existing resource.

This one-line change makes it possible to use oauth2's _request call to send a PATCH request with such a body. @ciaranj please take a look.

satori-stan
satori-stan approved these changes Oct 10, 2016
View reviewed changes
Copy link

@satori-stan satori-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on this change. There is a previous request requesting the same (with different method). Any one would do. Both could add DELETE method to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@satori-stan satori-stan satori-stan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jankeromnes @satori-stan