Skip to content

Enable differing domains for OAuth 2 requests #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable differing domains for OAuth 2 requests #341

wants to merge 1 commit into from

Conversation

samsullivan
Copy link

@samsullivan samsullivan commented Jan 11, 2018 •
edited
Loading

This solves #313 by only prepending this._baseSite to URLs if they don't start with /https?:/. For example, Facebook uses differing domains for these requests:

@samsullivan
Copy link
Author

Maintainers: I didn't modify the constructor to make baseSite optional, because I wanted to keep my changes to a minimum. I'm happy to update this further, if you don't like this design.

@samsullivan samsullivan mentioned this pull request Jan 11, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsullivan