Skip to content

Commit a984c7e

Browse files
authored
Add @triggerHtmlTag in docs and add notes to migrate to v9.x (#1034)
1 parent 1068d26 commit a984c7e

File tree

2 files changed

+28
-8
lines changed

2 files changed

+28
-8
lines changed

docs/app/templates/public-pages/docs/api-reference.gts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,11 @@ import { LinkTo } from '@ember/routing';
122122
<td>The component to render as trigger instead of the default trigger
123123
component.</td>
124124
</tr>
125+
<tr>
126+
<td>triggerHtmlTag</td>
127+
<td><code>String</code></td>
128+
<td>(Default: <code>'div'</code>) The tag of the trigger component</td>
129+
</tr>
125130
<tr>
126131
<td>verticalPosition</td>
127132
<td><code>String</code></td>
@@ -209,7 +214,10 @@ import { LinkTo } from '@ember/routing';
209214
<tr>
210215
<td>htmlTag</td>
211216
<td>String</td>
212-
<td>(Default: <code>'div'</code>) The tag of the trigger component</td>
217+
<td>(Default:
218+
<code>'div'</code>) The tag of the trigger component (Note: If you are
219+
using the yielded trigger component, please use
220+
<code>@triggerHtmlTag</code>)</td>
213221
</tr>
214222
<tr>
215223
<td>title</td>

docs/app/templates/public-pages/docs/migrate-8-0-to-9-0.gts

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,14 @@ import { LinkTo } from '@ember/routing';
5454
</li>
5555
<li>
5656
<p>
57-
Passing
58-
<code>@dropdownId</code>
59-
wasn't working correctly without using custom modifiers and was
60-
undocumented. Remove this parameter and use the
61-
<code>uniqueId</code>
62-
property from the public API instead.
57+
If you are using
58+
<code>@htmlTag</code>
59+
on the yielded trigger component (for example,
60+
<code>&lt;dd.Trigger @htmlTag="span"&gt;</code>) replace it with
61+
<code>&lt;BasicDropdown @triggerHtmlTag="span"&gt;</code>
62+
This change is required to fix Glint v2 typing issues.
6363
<br />
64-
<small><i>(Deprecation added in 8.8)</i></small>
64+
<small><i>(Deprecation added in 8.10)</i></small>
6565
</p>
6666
</li>
6767
<li>
@@ -91,6 +91,18 @@ import { LinkTo } from '@ember/routing';
9191
<small><i>(Deprecation added in 8.9)</i></small>
9292
</p>
9393
</li>
94+
<li>
95+
<p>
96+
Passing
97+
<code>@dropdownId</code>
98+
wasn't working correctly without using custom modifiers and was
99+
undocumented. Remove this parameter and use the
100+
<code>uniqueId</code>
101+
property from the public API instead.
102+
<br />
103+
<small><i>(Deprecation added in 8.8)</i></small>
104+
</p>
105+
</li>
94106
</ul>
95107

96108
<div class="doc-page-nav">

0 commit comments

Comments
 (0)