Decrease recentCutoff to 0

nebril · nbusseneau · commit 89040f6c3a46 · 2026-03-10T16:57:07.000+01:00
It seems like we are using single-workflow dependencies for now anyway
and we are getting hit by the cutoff occasionally.

Until we actually have multiple workflows per dependency, we can set
this to 0.

Signed-off-by: Maciej Kwiek &lt;mkwiek@cisco.com&gt;
diff --git a/internal/handlers/workflow_processor.go b/internal/handlers/workflow_processor.go
@@ -317,7 +317,7 @@ func (w *WorkflowProcessor) checkTriggerDependency(ctx context.Context, dependsO
 }
 
 const commentSince = -3 * time.Hour
-const recentCutoff = -3 * time.Minute
+const recentCutoff = 0 // lets revisit this value if we see too many comments being posted due to the dependency check
 const commentLookbackLimit = 100
 
 // processDependantWorkflows checks if the completed workflow run satisfies any trigger dependencies

Original file line number	Diff line number	Diff line change
`@@ -317,7 +317,7 @@ func (w *WorkflowProcessor) checkTriggerDependency(ctx context.Context, dependsO`
`317`	`317`	`}`
`318`	`318`
`319`	`319`	`const commentSince = -3 * time.Hour`
`320`		`-const recentCutoff = -3 * time.Minute`
	`320`	`+const recentCutoff = 0 // lets revisit this value if we see too many comments being posted due to the dependency check`
`321`	`321`	`const commentLookbackLimit = 100`
`322`	`322`
`323`	`323`	`// processDependantWorkflows checks if the completed workflow run satisfies any trigger dependencies`