perf: drop finalizer on Reader

lmb · ti-mo · commit 604453a8fdfd · 2025-09-08T14:45:28.000+02:00
It's not possible to call Reader.Close from a Cleanup, which indicates
that it's probably not the right thing to do here.

Drop the finalizer.

Signed-off-by: Lorenz Bauer &lt;lmb@isovalent.com&gt;
diff --git a/perf/reader.go b/perf/reader.go
@@ -8,7 +8,6 @@ import (
 	"fmt"
 	"io"
 	"os"
-	"runtime"
 	"sync"
 	"time"
 
@@ -261,7 +260,6 @@ func NewReaderWithOptions(array *ebpf.Map, perCPUBuffer int, opts ReaderOptions)
 	if err = pr.Resume(); err != nil {
 		return nil, err
 	}
-	runtime.SetFinalizer(pr, (*Reader).Close)
 	return pr, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ import (`
`8`	`8`	`"fmt"`
`9`	`9`	`"io"`
`10`	`10`	`"os"`
`11`		`- "runtime"`
`12`	`11`	`"sync"`
`13`	`12`	`"time"`
`14`	`13`
`@@ -261,7 +260,6 @@ func NewReaderWithOptions(array *ebpf.Map, perCPUBuffer int, opts ReaderOptions)`
`261`	`260`	`if err = pr.Resume(); err != nil {`
`262`	`261`	`return nil, err`
`263`	`262`	`}`
`264`		`- runtime.SetFinalizer(pr, (*Reader).Close)`
`265`	`263`	`return pr, nil`
`266`	`264`	`}`
`267`	`265`