Fix bug in unseal_all where it will panic if there is no protected_at… #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for this contribution @nicklaswj. Given we've seen bugs like this before, we will need to add a test case for it. We will add a test to this PR and merge. |
coderdan
approved these changes
Sep 27, 2024
Contributor
coderdan
left a comment
coderdan
left a comment
There was a problem hiding this comment.
Thanks for this @nicklaswj. I verified that this fixes the issue and added a confirmation test. I'll add some tests in a subsequent PR but this should unblock you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in unseal_all where it will panic if there is no protected_attributes