Reintroduce fn unseal and fn unseal_all on EncryptedTable + mak…
#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e `fn encrypt_primary_key_parts` public again
|
Hey @nicklaswj, it looks like you're depending on some internal stuff that was never meant to be publicly consumable. Maintaining this makes it tricky for us to make updates to encryption without breaking things. I'll approve this for now so that you are unblocked but we should have a chat about your goals and what a stable API could look like so that we can ensure backwards compatibility. |
coderdan
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the functions
EncryptedTable::unsealandEncryptedTable::unseal_alland additionally makesfn encrypt_primary_key_partspublic again. These changes are needed to make object-safe subset ofEncryptedTable