refactor: streamline log target macro to 2-parameter format

Eliminate redundant third parameter by using stringify!() to automatically
convert constant names to string values. This makes adding new targets even
simpler and reduces potential for errors.

Key improvements:
- Macro now takes (CONST_NAME, field_name) instead of (CONST_NAME, field_name, "string")
- Uses stringify!($const_name) to automatically generate string from identifier
- Target strings are now uppercase (e.g., "DEVELOPMENT", "AUTHENTICATION")
- Updated tests to use constants instead of hardcoded strings
- Updated documentation to reflect simplified 2-parameter syntax

Benefits:
- Eliminates redundant manual string parameter
- Impossible to have mismatched constant/string pairs
- Even cleaner single-source-of-truth approach
- Consistent string generation from identifiers

Example: Adding (NEW_TARGET, new_target_level) automatically creates:
- const NEW_TARGET: &str = "NEW_TARGET"
- LogTargetLevels field: new_target_level: LogLevel
- Environment variable: CS_LOG__NEW_TARGET_LEVEL

Author: tobyhede

DEVELOPMENT.md

@@ -572,13 +572,15 @@ To add a new log target, you only need to add **one line** to the macro in `pack
 
 ```rust
 define_log_targets!(
-    (DEVELOPMENT, development_level, "development"),
-    (AUTHENTICATION, authentication_level, "authentication"),
+    (DEVELOPMENT, development_level),
+    (AUTHENTICATION, authentication_level),
     // ... existing targets ...
-    (NEW_TARGET, new_target_level, "new_target"), // <- Add this line
+    (NEW_TARGET, new_target_level), // <- Add this line
 );
 ```
 
+The constant name (e.g., `NEW_TARGET`) is automatically converted to a string value using `stringify!()`, so `NEW_TARGET` becomes `"NEW_TARGET"` for use in logging calls.
+
 This automatically:
 - Creates the `NEW_TARGET` constant for use in logging calls
 - Generates the `new_target_level` field in `LogTargetLevels` struct

packages/cipherstash-proxy/src/log/mod.rs

@@ -49,7 +49,9 @@ mod tests {
     use crate::config::LogLevel;
 
     use super::*;
-    use crate::log::targets::LogTargetLevels;
+    use crate::log::targets::{
+        LogTargetLevels, AUTHENTICATION, CONTEXT, DEVELOPMENT, KEYSET, MAPPER, PROTOCOL, SCHEMA,
+    };
     use crate::test_helpers::MockMakeWriter;
     use tracing::dispatcher::set_default;
     use tracing::{debug, error, info, trace, warn};
@@ -136,48 +138,48 @@ mod tests {
         let _default = set_default(&subscriber.into());
 
         // with development level 'info', info should be logged but not debug
-        debug!(target: "development", "debug/development");
-        info!(target: "development", "info/development");
+        debug!(target: DEVELOPMENT, "debug/development");
+        info!(target: DEVELOPMENT, "info/development");
         let log_contents = make_writer.get_string();
         assert!(!log_contents.contains("debug/development"));
         assert!(log_contents.contains("info/development"));
 
         // with authentication level 'debug', debug should be logged but not trace
-        trace!(target: "authentication", "trace/authentication");
-        debug!(target: "authentication", "debug/authentication");
+        trace!(target: AUTHENTICATION, "trace/authentication");
+        debug!(target: AUTHENTICATION, "debug/authentication");
         let log_contents = make_writer.get_string();
         assert!(!log_contents.contains("trace/authentication"));
         assert!(log_contents.contains("debug/authentication"));
 
         // with context level 'error', error should be logged but not warn
-        warn!(target: "context", "warn/context");
-        error!(target: "context", "error/context");
+        warn!(target: CONTEXT, "warn/context");
+        error!(target: CONTEXT, "error/context");
         let log_contents = make_writer.get_string();
         assert!(!log_contents.contains("warn/context"));
         assert!(log_contents.contains("error/context"));
 
         // with keyset level 'trace', trace should be logged
-        trace!(target: "keyset", "trace/keyset");
+        trace!(target: KEYSET, "trace/keyset");
         let log_contents = make_writer.get_string();
         assert!(log_contents.contains("trace/keyset"));
 
         // with protocol level 'info', info should be logged but not debug
-        debug!(target: "protocol", "debug/protocol");
-        info!(target: "protocol", "info/protocol");
+        debug!(target: PROTOCOL, "debug/protocol");
+        info!(target: PROTOCOL, "info/protocol");
         let log_contents = make_writer.get_string();
         assert!(!log_contents.contains("debug/protocol"));
         assert!(log_contents.contains("info/protocol"));
 
         // with mapper level 'info', info should be logged but not debug
-        debug!(target: "mapper", "debug/mapper");
-        info!(target: "mapper", "info/mapper");
+        debug!(target: MAPPER, "debug/mapper");
+        info!(target: MAPPER, "info/mapper");
         let log_contents = make_writer.get_string();
         assert!(!log_contents.contains("debug/mapper"));
         assert!(log_contents.contains("info/mapper"));
 
         // with schema level 'info', info should be logged but not debug
-        debug!(target: "schema", "debug/schema");
-        info!(target: "schema", "info/schema");
+        debug!(target: SCHEMA, "debug/schema");
+        info!(target: SCHEMA, "info/schema");
         let log_contents = make_writer.get_string();
         assert!(!log_contents.contains("debug/schema"));
         assert!(log_contents.contains("info/schema"));

packages/cipherstash-proxy/src/log/targets.rs

@@ -3,10 +3,10 @@ use serde::Deserialize;
 
 // Define all log targets in one place
 macro_rules! define_log_targets {
-    ($(($const_name:ident, $field_name:ident, $target_str:literal)),* $(,)?) => {
-        // Generate target constants
+    ($(($const_name:ident, $field_name:ident)),* $(,)?) => {
+        // Generate target constants with automatic string generation
         $(
-            pub const $const_name: &str = $target_str;
+            pub const $const_name: &str = stringify!($const_name);
         )*
 
         // Generate LogTargetLevels struct with all target level fields
@@ -64,18 +64,18 @@ macro_rules! define_log_targets {
 }
 
 define_log_targets!(
-    (DEVELOPMENT, development_level, "development"),
-    (AUTHENTICATION, authentication_level, "authentication"),
-    (CONFIG, config_level, "config"),
-    (CONTEXT, context_level, "context"),
-    (ENCODING, encoding_level, "encoding"),
-    (ENCRYPT, encrypt_level, "encrypt"),
-    (DECRYPT, decrypt_level, "decrypt"),
-    (ENCRYPT_CONFIG, encrypt_config_level, "encrypt_config"),
-    (KEYSET, keyset_level, "keyset"),
-    (MIGRATE, migrate_level, "migrate"),
-    (PROTOCOL, protocol_level, "protocol"),
-    (PROXY, proxy_level, "proxy"),
-    (MAPPER, mapper_level, "mapper"),
-    (SCHEMA, schema_level, "schema"),
+    (DEVELOPMENT, development_level),
+    (AUTHENTICATION, authentication_level),
+    (CONFIG, config_level),
+    (CONTEXT, context_level),
+    (ENCODING, encoding_level),
+    (ENCRYPT, encrypt_level),
+    (DECRYPT, decrypt_level),
+    (ENCRYPT_CONFIG, encrypt_config_level),
+    (KEYSET, keyset_level),
+    (MIGRATE, migrate_level),
+    (PROTOCOL, protocol_level),
+    (PROXY, proxy_level),
+    (MAPPER, mapper_level),
+    (SCHEMA, schema_level),
 );