Refactor insert tests #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyhede
force-pushed
the
refactor-param-tests
branch
from
7c89366 to
a68e255
Compare
freshtonic
approved these changes
May 30, 2025
Contributor
freshtonic
left a comment
freshtonic
left a comment
There was a problem hiding this comment.
Nice work - approved with suggestion for the bool thing.
tobyhede
force-pushed
the
refactor-param-tests
branch
3 times, most recently
from
76f8e64 to
5f51348
Compare
tobyhede
force-pushed
the
refactor-param-tests
branch
from
5f51348 to
6be03a4
Compare
tobyhede
force-pushed
the
refactor-param-tests
branch
from
6be03a4 to
ccf9d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies implementation in favour of a macro that generates variants for each column type.
Covers