Refactor ReactHostImpl to simplify logging (facebook#44170)

Summary:
Pull Request resolved: facebook#44170

Addressing following logging issues with ReactHostImpl
- replacing `ReactSoftExceptionLogger.logSoftException()` directly with private `raiseSoftException()` at all call-sites
- `raiseSoftException()` already has a call to `log()`, hence removing that.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D56335797

fbshipit-source-id: 41e094b5dc25f23fa19cd391a85ea101c3ff9058

Author: arushikesarwani94

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java

@@ -624,27 +624,26 @@ NativeModule getNativeModule(String nativeModuleName) {
   /* package */
   @Nullable
   RuntimeExecutor getRuntimeExecutor() {
+    final String method = "getRuntimeExecutor()";
+
     final ReactInstance reactInstance = mReactInstanceTaskRef.get().getResult();
     if (reactInstance != null) {
       return reactInstance.getBufferedRuntimeExecutor();
     }
-    ReactSoftExceptionLogger.logSoftException(
-        TAG,
-        new ReactNoCrashSoftException("Tried to get runtime executor while instance is not ready"));
+    raiseSoftException(method, "Tried to get runtime executor while instance is not ready");
     return null;
   }
 
   /* package */
   @Nullable
   CallInvokerHolder getJSCallInvokerHolder() {
+    final String method = "getJSCallInvokerHolder()";
+
     final ReactInstance reactInstance = mReactInstanceTaskRef.get().getResult();
     if (reactInstance != null) {
       return reactInstance.getJSCallInvokerHolder();
     }
-    ReactSoftExceptionLogger.logSoftException(
-        TAG,
-        new ReactNoCrashSoftException(
-            "Tried to get JSCallInvokerHolder while instance is not ready"));
+    raiseSoftException(method, "Tried to get JSCallInvokerHolder while instance is not ready");
     return null;
   }
 
@@ -667,16 +666,12 @@ public void onActivityResult(
             + "\", data = \""
             + data
             + "\")";
-    log(method);
 
     ReactContext currentContext = getCurrentReactContext();
     if (currentContext != null) {
       currentContext.onActivityResult(activity, requestCode, resultCode, data);
     } else {
-      ReactSoftExceptionLogger.logSoftException(
-          TAG,
-          new ReactNoCrashSoftException(
-              "Tried to access onActivityResult while context is not ready"));
+      raiseSoftException(method, "Tried to access onActivityResult while context is not ready");
     }
   }
 
@@ -685,16 +680,12 @@ public void onActivityResult(
   @Override
   public void onWindowFocusChange(boolean hasFocus) {
     final String method = "onWindowFocusChange(hasFocus = \"" + hasFocus + "\")";
-    log(method);
 
     ReactContext currentContext = getCurrentReactContext();
     if (currentContext != null) {
       currentContext.onWindowFocusChange(hasFocus);
     } else {
-      ReactSoftExceptionLogger.logSoftException(
-          TAG,
-          new ReactNoCrashSoftException(
-              "Tried to access onWindowFocusChange while context is not ready"));
+      raiseSoftException(method, "Tried to access onWindowFocusChange while context is not ready");
     }
   }
 
@@ -705,7 +696,7 @@ public void onWindowFocusChange(boolean hasFocus) {
   @ThreadConfined(UI)
   @Override
   public void onNewIntent(Intent intent) {
-    log("onNewIntent()");
+    final String method = "onNewIntent(intent = \"" + intent + "\")";
 
     ReactContext currentContext = getCurrentReactContext();
     if (currentContext != null) {
@@ -723,9 +714,7 @@ public void onNewIntent(Intent intent) {
       }
       currentContext.onNewIntent(getCurrentActivity(), intent);
     } else {
-      ReactSoftExceptionLogger.logSoftException(
-          TAG,
-          new ReactNoCrashSoftException("Tried to access onNewIntent while context is not ready"));
+      raiseSoftException(method, "Tried to access onNewIntent while context is not ready");
     }
   }