Skip to content

Commit fbf9c43

Browse files
zhongwuzwfacebook-github-bot
authored andcommitted
Remove _logWarnIfCreateRootViewWithBridgeIsOverridden (facebook#44271)
Summary: Fixes customizeRootView migration comment. cc cipolleschi ## Changelog: [IOS] [FIXED] - Fixes customizeRootView migration comment Pull Request resolved: facebook#44271 Test Plan: ![image](https://github.com/facebook/react-native/assets/5061845/bf8b7628-9c23-4920-80bb-72b3ab08fbe3) Reviewed By: christophpurrer Differential Revision: D56821755 Pulled By: cipolleschi fbshipit-source-id: 5f85929d35ffc8768e5a7f1e76d738613bc70b14
1 parent de1967d commit fbf9c43

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
5454
if (self.newArchEnabled || self.fabricEnabled) {
5555
[RCTComponentViewFactory currentComponentViewFactory].thirdPartyFabricComponentsProvider = self;
5656
}
57-
[self _logWarnIfCreateRootViewWithBridgeIsOverridden];
5857
[self customizeRootView:(RCTRootView *)rootView];
5958

6059
self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
@@ -96,21 +95,6 @@ - (UIView *)createRootViewWithBridge:(RCTBridge *)bridge
9695
return rootView;
9796
}
9897

99-
// TODO T173939093 - Remove _logWarnIfCreateRootViewWithBridgeIsOverridden after 0.74 is cut
100-
- (void)_logWarnIfCreateRootViewWithBridgeIsOverridden
101-
{
102-
SEL selector = @selector(createRootViewWithBridge:moduleName:initProps:);
103-
IMP baseClassImp = method_getImplementation(class_getInstanceMethod([RCTAppDelegate class], selector));
104-
IMP currentClassImp = method_getImplementation(class_getInstanceMethod([self class], selector));
105-
if (currentClassImp != baseClassImp) {
106-
NSString *warnMessage =
107-
@"If you are using the `createRootViewWithBridge` to customize the root view appearence,"
108-
"for example to set the backgroundColor, please migrate to `customizeRootView` method.\n"
109-
"The `createRootViewWithBridge` method is not invoked in bridgeless.";
110-
RCTLogWarn(@"%@", warnMessage);
111-
}
112-
}
113-
11498
- (UIViewController *)createRootViewController
11599
{
116100
return [UIViewController new];

0 commit comments

Comments
 (0)